I would wager you never entered a value for the branch, but rather used the displayed default which is pre-filled as "master". Thus the $:/Github/Branch tiddler was never created in your wiki (it isn't new for 5.1.23). Like all the other tiddlers for the Github saver, it is only created when you enter a value.
Have a look at https://tiddlywiki.com/empty.html#%24%3A%2FControlPanel to see what I mean, the branch is pre-filled with a default value. Even backspacing by a single character and then re-typing it will actually create the tiddler. Now in 5.1.23 the displayed default value ("master"), and the default actually used by the saver ("main" in 5.1.23 whereas it used to be "master" in 5.1.22) are no longer the same, causing the save to fail. Personally I think the pre-filled default value is deceiving and we should not use one. I've had similar issues in other contexts where the <$edit-text> widget gives the appearance that a tiddler exists but it just the default value being shown in the absence of the tiddler. On Thursday, December 24, 2020 at 9:59:23 PM UTC+1 Mark S. wrote: > So I guess that configuration tiddler $:/GitHub/Branch was added to 5.1.23 > (it doesn't seem to be in 5.1.22) ? > I'm trying to understand why my existing configuration didn't persist > through the upgrade process, no matter > what the default attribute provided. All the other configurations (path, > api, repository, file name) persisted. > > On Thursday, December 24, 2020 at 11:49:59 AM UTC-8 saq.i...@gmail.com > wrote: > >> @Mark S >> >> I posted some details in the issue I created for this: >> https://github.com/Jermolene/TiddlyWiki5/issues/5317 >> >> The text you see is from the default attribute of the <$edit-text> in the >> UI, see >> https://github.com/Jermolene/TiddlyWiki5/blob/master/core/ui/ControlPanel/Saving/GitHub.tid#L13 >> >> When the underlying tiddler does not exist: >> - the UI shows the branch as "master". >> - the code after the recent changes, uses "main" instead. >> >> On Thursday, December 24, 2020 at 8:46:39 PM UTC+1 Mark S. wrote: >> >>> I don't understand. My branch was specified (it shows as "master" in the >>> saver panel). But I had to delete it and type it in again to get it to >>> work. So is there an internal 5.1.23 configuration file that has to be >>> overwritten? >>> >>> Thanks! >>> >>> On Thursday, December 24, 2020 at 11:37:56 AM UTC-8 saq.i...@gmail.com >>> wrote: >>> >>>> Yep, we have our first bug. The placeholder shown when the branch has >>>> not been specified is "master", but the code uses "main" for the branch. >>>> >>>> The interim fix for users is fortunately easy, just empty and re-fill >>>> the branch name. >>>> >>>> On Thursday, December 24, 2020 at 8:33:15 PM UTC+1 Saq Imtiaz wrote: >>>> >>>>> Hmm. I am a bit surprised that worked. I wonder if the changes made to >>>>> the Github saver to reflect the change made by Github to the default >>>>> branch (master vs main) got something wrong. >>>>> >>>>> On Thursday, December 24, 2020 at 8:30:50 PM UTC+1 Ste wrote: >>>>> >>>>>> Cheers Saq! >>>>>> Refilled in all fields and for some reason.. It works..! >>>>>> >>>>>> >>>>>> On Thursday, 24 December 2020 at 19:25:22 UTC Ste wrote: >>>>>> >>>>>>> Just reread my own post.. Let me clarify... Using the git hub saving >>>>>>> in tiddlywiki works in pre release but not from newly upgraded. This is >>>>>>> true both with the file on my phone or the new file uploaded to git hub >>>>>>> and >>>>>>> trying the github saver from there. >>>>>>> XMLHttpRequest error code: 401 >>>>>>> Sorry. It's a 401. Not a 404.. I'm losing the plot.. Mulled wine >>>>>>> time! >>>>>>> >>>>>>> On Thursday, 24 December 2020 at 19:10:55 UTC Ste wrote: >>>>>>> >>>>>>>> I'm sure it's my own muppetry and that I'm trying to do this on my >>>>>>>> phone but, I can succesfully upload pre upgrade wiki but not post >>>>>>>> upgrade >>>>>>>> wiki to github using the git hub saving mechanism. I am getting a 404 >>>>>>>> error. Any one else finding this? >>>>>>> >>>>>>> -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/26ece1cc-68f6-4496-972b-a0fca71c8992n%40googlegroups.com.
