Hi Vincent,
I've updated the plugins and have done some testing..
I have problems with moving colomns in quite a simple test case: in my
setup (Win7 x64 + Opera 12.16 + TW 2.6.5 + latest .min versions of the
plugins + some plugins -- STP, NestedSlidersPlugin, minor tweaks) with a
tiddler as simple as
Start with text
|a|c|b|
|d|f|e|
|g|j|i|
end with text
and all other tiddlers closed, when I push the button to move any colomn, I
don't see any change, the saving message appears in a second or two, I'm
not able to do anything else with my TW (cursor doesn't change as I move it
over different buttons) and when I refresh the page, the change is applied
(the colomn is moved).
I like the new mouseover popups with options, very nice that now each one
is shorter than the previous thing that contained options for all the
plugins.
While testing the colomn moving issue, I've found a new bug. To reproduce,
create a tiddler with the following content and follow the instructions:
Try to edit the text after the table: mouseover the textblock and click
(for me, instead of opening the block editing is opened for the whole
tiddler content), try to add "2 " before the class brackets (in the
beginning of the line), press ctrl+enter. The change is not displayed for
me, and neither it is saved (open the content by the "edit" toolbar
button). Also , the preview is of wrong widths and has much more height
because of that.
|a|
{{DDn{v2.0.5: more text}}}
By the way, the difference in the version numbers of TWtid/TWted add a bit
of inconvenience for tracking changes/bugs, so I'd recommend keep the
version numbers the same by "dumb" incrementing of those that were not
changed and stating that in the changelog.
Another new (minor) bug: inline editing of tiddler title doesn't change its
"modified" date.
Despite adding the tiddler selected classes, the styling is not applied
correctly to the previewer. However, I've also noticed that the previewer
is currently a span element instead of div, which may be the origin of the
problem.. In you release notes you've written about some errors when the
viewer class is added -- that may be connected with the fact that this
class is added to elements generated by the view macro, and some
refreshing/.. stuff is applied to such things.
Opera DragonFly tells me that there's a tremendous amount (>500) of
unhandled errors that origin from the TWtid.min line 1536
(tiddler_titlemethod). Error text is "Cannot convert 'a' to object" (
a is the only argument in the .min version).
Looks like an arbitrary popup have become "close on mouseout"-enabled (this
happens with tag macro, references toolbar command popups and others). As
you've done some popup business recently, I think it's worth debugging at
the first place.
Ok, looks like that's all for today :)
Best regards,
Yakov.
воскресенье, 10 ноября 2013 г., 17:12:59 UTC+4 пользователь Vincent Yeh
написал:
>
> Yakov,
>
> I was supposed to do something else but couldn't get it off my mind, so
> decided to spent some time on the table column moving issue (row moving
> seems to work fine). I found two situations that cause the column moving
> very slow and one that causes infinite loop:
>
> 1. when there are empty cells in a row
> 2. when using TWtcalc and some of the moved cells contain block
> references (such as =sum(A1:B3))
> 3. table at the end of a tiddler and does not end with a new line
> (infinite loop)
>
> The reasons are
>
> 1. a bug that I introduced in a recent bug fix for another situation
> (this is fixed in my current snapshot and will go in the next release)
> 2. In TWtcalc I haven't done auto adjustment on block references yet
> (single cell references are auto-adjusted upon copy-and-pasting,
> row/column
> moving, and sorting), so this issue shall continue for a while
> 3. a situation that I did not think of (fixed in the current snapshot
> and goes in the next release)
>
> *Row/Column moving does not work for tables with missing cells yet.*
>
> Do the above three situations cover yours or you have something different?
>
> Vincent
>
> On Wednesday, October 2, 2013 3:24:24 AM UTC+8, Yakov wrote:
>>
>> Hi Vincent,
>>
>> yeap, like you have noticed, your "second" message (after my reply), but
>> also the two others -- got deleted somewhy; anyway, I got them in my email
>> as I'm subscribed for the comments.
>>
>> Now, "let's talk business" :)
>>
>> The table row/colomn moving kind of works, but very slowly. In a simple
>> example
>>
>> |a|b|
>> |c|d|
>>
>> moving colomns takes 6-12 seconds, moving rows -- ~4 seconds; it seems
>> that the moving is stored each time but it is not always displayed.. (for
>> better testing I disabled all other plugins and even opened just one
>> tiddler with such table, but still in both Opera and FF I get these
>> problems). By the way, this may be of interest (see the updates to the most
>> voted answer):
>> http://stackoverflow.com/questions/268490/jquery-document-createelement-equivalent
>>
>> By the way, as far as I understand, this
>>
>> Although I do not know the cause, the fix is easy: assign the content
>>> text after, rather then at the same time of, the creation of editbox with
>>> jQuery. That is, separate the codes from
>>>
>>> $ta = jQuery('<textarea>'+txt+'</textarea>');
>>>
>>> to
>>>
>>> $ta = jQuery('<textarea></textarea>');
>>> $ta.val(txt);
>>>
>> is because creating element using this syntax
>> http://api.jquery.com/jQuery/#jQuery2 actually parses html, and for
>> textarea parsed text is set, but if you set the value via val, you get
>> it "as is".
>>
>> The html entitites issue, like you said, is gone and the
>> chkTWtedEditAllTables option now works as expected, great.
>>
>> Some ideas/notes for the issues:
>>
>> 1.3 May be adding some classes that content wrappers have (like "tiddler
>> selected" or "viewer") to the previewer will make styling the same.
>>
>> 2.1 I'd say that's somewhat ok if I can add new lines in an "edit list
>> item" area by pressing some keys. For now, I can only copy-paste the
>> newline symbol from elsewhere (all enter, ctrl+enter, shift+enter,
>> alt+enter either don't do anything or close the edit area), but by
>> adding a newline a list item before, after and of any level can be created.
>>
>> 2.2 Wow, this works! (although causes some jumping of the screen up and
>> down and, like you said, doesn't work well with list items of different
>> level)
>>
>> 4.1 in the tiddler you sited it is said:
>>
>> move the cursor to the right until the focusing borders become larger
>>>
>>
>> well, the problem is on moving to the right the focusing borders either
>> disapper (for text blocks) or don't become larger (list items) and the only
>> way [in my setup] to get the whole transcluded content selected is to put
>> mouse somewhere *on the left* of the content.
>>
>> 6.1 Ok.. you can ask me some direct questions, but "in vacuum".. Well,
>> the two main function to look at are .subWikifyUnterm (it's simpler, but
>> is used only "once" -- in the .subWikify) and .subWikifyTerm (it is
>> used, for instance, in some formatters like heading, and uses
>> termRegExprproperty of formatters). Another important note is that it's
>> easier to
>> start from formatters and then dig wikifying. Finally, it's very important
>> (and not obvious) that formatters keep an eye on the w.nextMatch index:
>> see, for instance, the macro formatter. [*]
>>
>> Honestly, I haven't overviewed the whole thing yet.
>>
>> Best regards,
>> Yakov.
>>
>> [*] https://github.com/TiddlyWiki/tiddlywiki/blob/master/js/Wikifier.js
>> https://github.com/TiddlyWiki/tiddlywiki/blob/master/js/Formatter.js
>>
>>
>>>>
>>>>
>>>> [TWtid/TWted/TWtable 2.0.5 + TW 2.6.5 with STP 2.4.0 + Opera 12.16 +
>>>> Win7 x64]
>>>>
>>>> 0. Separate bugs/notes/questions
>>>>
>>>>
>>> 0.2 The "i-show-the-element-to-edit-on-click-here" border still appears
>>>> around the displayArea (id=tiddlerDisplay) and elements with the tagged,
>>>> tagging classes [which is not desirable]
>>>>
>>> 0.3 If TWted is not launched, but TWtid is (with or without TWtable),
>>>> backstage is not displayed and on start no tiddlers (from DefaultTiddlers)
>>>> is displayed
>>>>
>>>>
>>> I do not have these two issues with IE10/Win8 x64 (the only browser/OS
>>> combo at hand right now). Will check with other combinations next week. (We
>>> are having a four day long weekend for the Moon festival, during which
>>> we usually have a gathering with families or a party with friends. But this
>>> time we are having a huge tropical storm.)
>>>
>>>
>>>> 1. Editing simple text
>>>>
>>>> 1.2 the previewer still doesn't work well with long texts because if
>>>> one starts editing its beginning, the preview of it is above the top end
>>>> of
>>>> the screen. Desired behaviour is to cut the previewer and make it
>>>> autoscroll. Is it the position of the cursor in the previewer which is
>>>> difficult to grab? I can suggest some solutions on this, but of'course it
>>>> all depends on the implentation.
>>>> 1.3 the previewer shows the content in a different styling, as if it
>>>> was in the SideBar -- this causes, for instant, displaying quotes with
>>>> simple indents and buttons from macros like <<tag>> not very notable
>>>>
>>> I am aware of these two for quite a while but still haven't figured a
>>> good solution yet. For 1.2 I am thinking of a "line previewer" which
>>> supposedly shows only one line of content. If it really works then it shall
>>> be easy to put over (and cover) the current line. But I haven't got it yet.
>>> For 1.3 I have no idea how to fix yet. Currently I just do 1) copy style
>>> and 2) call wikify() in TWtid.wikify_element(). I do not understand why it
>>> is not 100% reproduced. I tried to dig into the wikifier
>>> functions but unfortunately the key parts are just like Klingon to me.
>>>
>>>
>>>> 2. Editing lists
>>>>
>>>> editing of list items that already exist works fine, deleting them is
>>>> simple and changing the "order" (number of *) of a list item is easy,
>>>> but there are several issues, too:
>>>> 2.1 no way to edit new list items (aside editing the whote text). For
>>>> non-touchscreen devices that could work fine by pressing ctrl+enter
>>>>
>>> I do not have a decent solution for this yet. My workaround is to 1)
>>> edit the immediately preceding item and 2) make a new line at the end and
>>> start that new line with the desired list item.
>>>
>>>
>>>> 2.2 no way to move list items up and down (although one can copy-paste
>>>> the content from one list item to another and vise versa, that's not
>>>> fast..). Could work with alt+up/down
>>>>
>>> Ctrl-up/down should do the work, but currently it only works for items
>>> within the same level and fails when the item moves into a different level.
>>>
>>>
>>>> 2.3 for list item like this two:
>>>>
>>>> * text{{jD{
>>>> some content, like with
>>>> > citation
>>>> }}} some text after
>>>> * text +++[nested slider]
>>>> see NestedSlidersPlugin at TiddlyTools
>>>> === some text after
>>>>
>>>> it is only possible to edit the first line, although the list item is
>>>> somposed from the three lines in each case.. (I use such syntax regularly,
>>>> that's why I mention this complex example)
>>>>
>>> I never thought of such an interesting way to make a list item. Will
>>> spend time studying it later.
>>>
>>>
>>>> 3. Editing tables
>>>>
>>>> I haven't refactored all the tests here, but let's start from some
>>>> issues anyway:
>>>>
>>>> 3.1 a single cell is not styled correctly: somewhy it gets "bad" width
>>>> and sometimes occupies more lines then it's expected. Try this one:
>>>>
>>>> |single cell|
>>>>
>>>> for me, the right border is too much to the right; and this one
>>>>
>>>> |single cell single cell single cell single cell|
>>>>
>>>> occupies two lines (an ordinary monitor, not mobile); without TWted
>>>> this behaviour disappears.
>>>>
>>> Sure I'll try them later.
>>>
>>>
>>>>
>>>> 3.2 I still miss the "move colomn left/right" buttons, would be very
>>>> nice to have them
>>>>
>>> I'll think about it.
>>>
>>>
>>>> 3.3 Missing cells after other missing ones are not editable (cases like
>>>> this:
>>>>
>>>> |a|b|c|
>>>> |d|
>>>> |e|f|
>>>>
>>>> ), but I must admit, there's a workaround: edit the cell after d, then
>>>> the one next to it, then clear the first one (although that's not very
>>>> handy).
>>>>
>>> In principle this can be done in the plugin by determining the indices
>>> (row, col) of the "ought-to-be-there" cell, then create and append it,
>>> together with all the missing ones preceding it. It can be fixed.
>>>
>>>
>>>>
>>>> 4. Editing translcuded content
>>>>
>>>> Almost everything is ideal here (I haven't tested the transclusions
>>>> from the same tiddler, though). The only things are:
>>>>
>>>> 4.1 when transcluding with the <<tiddler>> macro, I can edit the
>>>> transcluded content, but can't edit the macro itself
>>>>
>>> Well, in the test case
>>> http://twtable.tiddlyspace.com/#%5B%5BTransclusion%20support%5D%5D it
>>> is possible. Could you tell me the differences between this test case and
>>> yours so I can find the key?
>>>
>>>
>>>> 4.2 There's a bug which I failed to create a separate simple example
>>>> for; because of this, I attach a slightly modified TW where I test most of
>>>> the InlineEditing stuff (I removed all the other plugins). To get the bug,
>>>> you'll need to click the "test" button in the tiddler
>>>> "InlineEditingPluginHere", choose the "4 Transclusions ..." and in the
>>>> opened tiddler to mouseover the first table and then move the mouse away.
>>>> What I get is the whole content of the tiddler is "compressed" by half.
>>>> May
>>>> be this is connected with the "wrong table widths" bug (3.1).
>>>>
>>> Will look into it as soon as I get time.
>>>
>>>
>>>>
>>>> 5. Complex content
>>>>
>>>> 5.1 "One-line" text blocks (without linebreaks \n) in some
>>>> surrounding, like
>>>>
>>>> * list item
>>>> text block
>>>> * list item
>>>>
>>>> can't be made "multiline": each enter, ctrl+enter and shift+entercauses
>>>> exiting the edit mode instead of adding a new line.
>>>>
>>> The above example works fine in my IE10/Win8 x64 here. Will check with
>>> more combinations next week.
>>>
>>>
>>>>
>>>> 5.2 Navigation with arrows is a desirable feature: now it's impossible
>>>> even to jump between different text blocks with arrow keyboard buttons
>>>> (which is possible for list items), and ideally it should be possible to..
>>>> well, navigate like in some office app -- in the example from 5.1 to jump
>>>> from the first list item to the text block by pressing "down", the same
>>>> for
>>>> jumping from the latter to the next list item etc.
>>>>
>>> I'd love this feature myself and will certainly think about it.
>>>
>>>
>>>>
>>>> 6 Using with MathJax and rewikification
>>>>
>>>> What MathJax (a library that creates math formulae using LaTeX syntax)
>>>> makes different is the speed of wikification: processing long formulae may
>>>> take several seconds. Current implementation (see below) adds a number of
>>>> formatters and hijacks wikify so that original wikify is used first,
>>>> and the math typesetting is applied to the whole text afterwards. This can
>>>> be changed to applying typesetting by formatters themselves for each
>>>> formulae, although I haven't tested performance of such implementation yet.
>>>>
>>>> *6.1* The main issue is rewikification. When a symbol is added/removed
>>>> or cursor is moved (and the "l" symbol is, hence, added in another
>>>> place), the *whole* content is wikified again (in the previewer). This
>>>> makes previewer almost useless once a big formula is added. In the archive
>>>> [1] you may find an example (the "elder" folder contains MathJax and a
>>>> copy
>>>> of "mainstream" PluginMathJax; in the main test file "InlineEditingPlugins
>>>> + MathJax test.html" there's TwFormulaePlugin which isn't much different
>>>> from PluginMathJax 1.3). To see how it works, open "InlineEditingPlugins +
>>>> MathJax test.html", click "tests", open "6 Extras: MathJax tests". Then,
>>>> copy the first line to another tiddler and play with it -- works fine.
>>>> Then, copy the part before "=================", try it again and see the
>>>> difference (in performance of the previewer). Finally, see the whole
>>>> tiddler "6 Extras: MathJax tests", try to edit the whole content with the
>>>> previewer: as some formulae are big, you won't see any preview of them
>>>> while editing.
>>>>
>>>> The question is -- can this behaviour be changed so that only parts of
>>>> wikitext *that are changed* are rewikified? Another way to improve the
>>>> situation is to make rewikification "inertial": add a parameter
>>>> txtDelayRewikificationMilliseconds which defines a minimal time gap
>>>> between rewikifications: this will allow at least to see the edited text.
>>>>
>>> I am suffering from this problem, too, and thought of partial
>>> wikification but could not get it as, like I mentioned above, I simply do
>>> not understand the key parts of the wikifier functions.
>>>
>>>
>>>> *6.2* The second and the third issues are written in the end of the
>>>> tiddler "6 Extras: MathJax tests". The positioning issue actually affects
>>>> not only formulae in this tiddler, but the text blocks as well (starting
>>>> from the second one). Click, for instance, the formulae E = c pi/2 * ....
>>>> -- the text isn't only taken from the wrong place, it also contains the
>>>> closing part of the "$$...$$" wrapper.. Yeap, like in the issue 2.3 it's
>>>> wrappers that are not handled well...
>>>>
>>> Thanks for making the test file. I will check with it next week.
>>>
>>>>
>>>> 6.3 The third issue is a minor one: alghouth it's supposed that the
>>>> text in the edit areas should be aligned to the left, it's aligned to the
>>>> center instead (for many of the parts of the "6 Extras: MathJax tests"
>>>> tiddler).
>>>>
>>>> -------------------------------------------
>>>>
>>>> So, that's all that I have gathered for now. There are some minor
>>>> issues that can be fixed in the next release as they can be fixed easily
>>>> (I
>>>> suppose), like 0.2, 1.3, (may be) 3.1; some issues to think of and which
>>>> can help reasonably improve workflow; and some major issues like 6.1, 2.1,
>>>> 2.2 in solving of which I'm really looking forward and with whick I would
>>>> like to help if there's something I can do (aside diving into the whole
>>>> source of TWtid/TWted, of'course). What do you think?
>>>>
>>> I'd love to have you help in these for sure, especially in the partial
>>> wikification thing. I really have problems understanding the codes.If you
>>> have any idea to achieve it without digging into the wikifier codes, I'd be
>>> more than happy to hear it.
>>>
>>> Thanks again for so much information and so much effort you put behind.
>>>
>>> Best,
>>> Vincent
>>>
>>>
>>> Best regards,
>>> Yakov.
>>>
>>> [1]
>>> http://yakovl.bplaced.net/TW/materials_for_discussions/InlineEditingPlugins%20+%20MathJax%20test.7z
>>>
>>
--
You received this message because you are subscribed to the Google Groups
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to tiddlywiki+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywiki@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
For more options, visit https://groups.google.com/groups/opt_out.
