Hi Pmario, really nice feedback. positive and constructive :)
Regarding the UUID: I did not even notice that, you have a very sharp eye. I will certainly take care of that. May I use your comment to forward this issue to the library maintainer of the uuid-generator I am using? Regarding your question about my github. I currently have two TW pull requests that I am waiting for to be accepted. 1) Allowing to specify a template in the context of the new-tiddler event <https://github.com/Jermolene/TiddlyWiki5/pull/1059> 2) Giving users of modal a chance to reference the underlying tiddler <https://github.com/Jermolene/TiddlyWiki5/pull/1045> Because my code depends on that, I wanted to wait with the upload to my repository till I get some clarity about these requests. Regards Felix <https://github.com/Jermolene/TiddlyWiki5/pull/1059> Am Mittwoch, 5. November 2014 19:34:31 UTC+1 schrieb PMario: > > Hi Felix, > I think your plugin will be a big success! I love mindmaps for > brainstorming :) > > ------- > > But I think there is a problem with the UUID generation. Your ID looks > like an , RFC 4122 UUID Version 4 (random) [1] > which has to have this format: xxxxxxxx-xxxx-*4*xxx-*y*xxx-xxxxxxxxxxxx > > x .. hex digit random generation > y .. has to be: 8, 9, a, b > > eg: 540618a7-ab80-4cbc-b634-6c809fc3575a > > Your IDs are ok, if you don't care about the standard, but it will be > confusing if 3rd party SW has to work with your ID. > Imo they'll expect a standard id. Since it's easy to change, I think, you > should make your ID standards compliant. > > > Do you have a github repo, to test the stuff? > > > have fun! > mario > > [1] http://en.wikipedia.org/wiki/Universally_unique_identifier > > > -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+unsubscr...@googlegroups.com. To post to this group, send email to tiddlywiki@googlegroups.com. Visit this group at http://groups.google.com/group/tiddlywiki. For more options, visit https://groups.google.com/d/optout.
