Hi Vladik
> core/modules/editor/engines/simple.js contains unimplemented
> createTextOperation and executeTextOperation functions:
These functions aren’t implemented for the simple editor because the toolbar
button mechanism doesn’t work properly without the iframe editor. The reason
for the iframe editor is that with a simple textarea, clicking on a toolbar
button loses the selection. Having said that, it sounds like you’ve got it
working somehow?
Best wishes
Jeremy
>
> Create a blank structure representing a text operation
> */
> SimpleEngine.prototype.createTextOperation = function() {
> return null;
> };
>
> /*
> Execute a text operation
> */
> SimpleEngine.prototype.executeTextOperation = function(operation) {
> };
>
> Due to some SOP constraints in environment where TiddlyWiki is run (ZeroNet)
> it's not always possible to use framed.js editor. I've patched
> core/modules/widgets/edit-text.js to load only simple.js version editor and
> copy-pasted these functions from frames.js with minor modifications. It works
> without any problems.
>
> I'm a beginner in JavaScript and not aware of possible problems introduced by
> this change. May I ask why these functions are not implemented? Is my fix is
> a proper fix? Could I commit it to the core? Visually everything seems to be
> OK, it works fine.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "TiddlyWikiDev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/tiddlywikidev/00f96b36-b86e-9644-69b6-5260c009230e%40valdikss.org.ru.
> <editor-simple-fix.txt>
--
You received this message because you are subscribed to the Google Groups
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/tiddlywikidev/DEF6F6F4-64E7-4EC0-AF2C-D829B6E2065A%40gmail.com.
