I'm really quite distressed at all of these modifications, because I spent quite a bit of time making sure that the CMake build system for Windows worked well on MinGW + GMake, MinGW64 + GMake, Visual C++ 32-bit and 64-bit + NMake, Visual C++ 32-bit + Visual Studio IDE, and MinGW cross-compiled on Linux. This is what I said earlier when we were discussing whether to merge the Unix build into CMake-- the CMake system is somewhat fragile. It works exactly as I designed it, but every piece of code in there is in there for a reason.
You have still not answered my previous comment about why you ripped out the 64BIT variable and broke MinGW64 builds. It should not be necessary to specify a minimum platform of Windows XP. Please describe the exact build problem you are having which inspired this patch. On 3/4/11 8:41 AM, ossm...@users.sourceforge.net wrote: > Revision: 4323 > http://tigervnc.svn.sourceforge.net/tigervnc/?rev=4323&view=rev > Author: ossman_ > Date: 2011-03-04 14:41:14 +0000 (Fri, 04 Mar 2011) > > Log Message: > ----------- > The Win64 headers don't like us requesting Windows 2000 as the minimum version > as that version did not have 64-bit support. > > Modified Paths: > -------------- > trunk/CMakeLists.txt > > Modified: trunk/CMakeLists.txt > =================================================================== > --- trunk/CMakeLists.txt 2011-03-04 14:31:32 UTC (rev 4322) > +++ trunk/CMakeLists.txt 2011-03-04 14:41:14 UTC (rev 4323) > @@ -138,7 +138,14 @@ > add_definitions(-DHAVE_CONFIG_H) > include_directories(${CMAKE_BINARY_DIR}) > > -add_definitions(-D_WIN32_IE=0x0500 -D_WIN32_WINNT=0x0500) > +# Minimum version is Windows 2000 (5.0) > +if(NOT CMAKE_CL_64) > + add_definitions(-D_WIN32_IE=0x0500 -D_WIN32_WINNT=0x0500) > +else() > + # Win64 doesn't like us requesting a Windows version that didn't have > + # 64-bit support. Request XP (5.1) instead. > + add_definitions(-D_WIN32_IE=0x0501 -D_WIN32_WINNT=0x0501) > +endif() > > add_subdirectory(common) > add_subdirectory(win) > > > This was sent by the SourceForge.net collaborative development platform, the > world's largest Open Source development site. > > ------------------------------------------------------------------------------ > What You Don't Know About Data Connectivity CAN Hurt You > This paper provides an overview of data connectivity, details > its effect on application quality, and explores various alternative > solutions. http://p.sf.net/sfu/progress-d2d > _______________________________________________ > Tigervnc-commits mailing list > tigervnc-comm...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/tigervnc-commits ------------------------------------------------------------------------------ What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d _______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
