Am 2011-05-11 10:14, schrieb Adam Tkac:
>> However, as I like to use packages on my servers, I stumbled over a
>> few minor things while building.
>> First, for the release you should update your autotools and run
>> 'autoreconf -fi' (maybe fix the warnings that show up too), otherwise
>> an outdated gettext.m4 will fail to detect glibc NLS support on 64-bit
>> platforms (with --enable-nls), because a pointer is casted to (int).
>> Second, after some thinking I decided to build a tigervnc-Xvnc as a
>> subpackage of the SLES11SP1 xorg-x11-server source RPM. This way I can
>> follow any xserver package updates (security, whatever) easily.
>> Integration required changing tigervnc's build procedure a bit.
>> Instead of copying xserver sources to tigervnc source tree, I copied
>> tigervnc sources into the xserver source tree. This works nicely, but
>> required some minor changes to the tigervnc sources, as you can see in
>> the attached patch.
>> tigervnc-rpm1.patch is a replacement for the mi/miinitext.c part of
>> xserver16.patch (without it some parts of xserver will complain about
>> the missing vncExtensionInit definition during linking).
>> tigervnc-rpm2.patch contains the corresponding change to the tigervnc
>> source.
>> I hope these 2 can be applied to your repository.
>
> Those two look fine for me, I will commit them today.
Thanks!
>> I have an additional hunk for vnc/Makefile.am, but this one is not
>> appropriate for general use (and can also be done via the make
>> invocation, maybe you prepend LIB_DIR with TIGERVNC_ though):
>> -TIGERVNC_SRCDIR=${top_srcdir}/../..
>> -LIB_DIR=${top_builddir}/../../common
>> +TIGERVNC_SRCDIR=${top_srcdir}/tigervnc
>> +LIB_DIR=${top_builddir}/tigervnc/common
>>
>> Is there a way turn this into an autoconf option like
>> --enable-tigervnc-within-xserver? I don't know autoconf enough to do
>> that myself.
>
> I would rather not to add this option because support for multiple build
> approaches to Xvnc is another non-trivial maintenance task for us. Is it
> possible to keep this part of the patch downstream? (i.e.
> distribution-specific patch).
Certainly, this is easy to handle. The only thing you might consider is
to rename LIB_DIR to TIGERVNC_LIB_DIR to make overriding more obvious
and also less likely to cause interaction with other Makefiles.
Franz
------------------------------------------------------------------------------
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
