On Sun, 05 Feb 2012 15:32:52 -0600 DRC <dcomman...@users.sourceforge.net> wrote:
> Perhaps I'm still missing something, because after examining the patch > again, I don't see where the original buffer corruption was occurring or > how your patch fixes it. Part of the difficulty in analyzing this patch > is that you seem to have taken the opportunity to move a lot of things > around to conform to your own personal preferences. I would ask you to > please reformulate the patch with as few changes as possible and to > clarify where the buffer corruption was occurring. > The specific bug I was reproducing was caused by the force solid code path, which kept "pixels" pointing at the frame buffer. To be able to audit the rest of the code for similar misuse, I needed to clear it up so it was easier to follow. Just the addition of const pointers required substantial changes. As part of this the JPEG code was changed to make it painfully obvious it behaves very differently from the other parts of the tight encoder. Rgds -- Pierre Ossman OpenSource-based Thin Client Technology System Developer Telephone: +46-13-21 46 00 Cendio AB Web: http://www.cendio.com A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing?
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
