On Fri, 29 Jun 2012 09:17:39 -0400
Brian Hinz <bph...@users.sourceforge.net> wrote:

> r4220 appears to be the cause of bug #3415308.  When I revert the change
> made in r4220 fluxbox and other apps that exhibit rendering artifacts along
> their window decorations all behave properly.  I have not seen any problems
> with this so far (limited testing), however Adam's commit note states
> that "Don't
> hook pixmaps in vncHooks, it fixes crash after XDrawArc call.". Attached is
> the patch I'm using, can someone look over it and verify whether or not
> there is still a problem with XDrawArc?
> 

Hooking pixmaps is fundamentally wrong as they are not part of what's
displayed, and will therefore never be directly transferred to the
client.

The fact that your patch fixes something is an indication that we are
overlooking some screen updates somewhere else. Unfortunately it's not
really trivial to figure out what and where. You have to find a simple
test case, and then start following the chain of draw commands and see
where a hook is either missing, or miscalculating the damaged region.

Rgds
-- 
Pierre Ossman           Software Development
Cendio AB               http://cendio.com
Teknikringen 8          http://twitter.com/ThinLinc
583 30 Linköping        http://facebook.com/ThinLinc
Phone: +46-13-214600    http://plus.google.com/112509906846170010689

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel

Reply via email to