On Mon, 16 Jul 2012 13:23:23 -0400 Brian Hinz <bph...@users.sourceforge.net> wrote:
> Hi Pierre, > > It looks like one of the randr patches you checked in between 4931 and 4935 > breaks backwards compatibility with xorg <= 7.5. I haven't dived in to see > what's wrong at all yet, but here's the compiler output (vanilla xorg 7.5 > sources used): > I did a diff against the randr interface in 1.11, and the bug you saw seems to be the only significant change. Does the included patch work for you? Rgds -- Pierre Ossman Software Development Cendio AB http://cendio.com Teknikringen 8 http://twitter.com/ThinLinc 583 30 Linköping http://facebook.com/ThinLinc Phone: +46-13-214600 http://plus.google.com/112509906846170010689 A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing?
Index: unix/xserver/hw/vnc/xvnc.cc
===================================================================
--- unix/xserver/hw/vnc/xvnc.cc (revision 4935)
+++ unix/xserver/hw/vnc/xvnc.cc (working copy)
@@ -1116,6 +1116,9 @@
if ((crtc->x >= width) || (crtc->y >= height)) {
/* Disable it */
ret = RRCrtcNotify(crtc, NULL, crtc->x, crtc->y, crtc->rotation,
+#if XORG >= 16
+ NULL,
+#endif
crtc->numOutputs, crtc->outputs);
if (!ret)
ErrorF("Warning: Unable to disable CRTC that is outside of new screen dimensions");
@@ -1131,6 +1134,9 @@
}
ret = RRCrtcNotify(crtc, mode, crtc->x, crtc->y, crtc->rotation,
+#if XORG >= 16
+ NULL,
+#endif
crtc->numOutputs, crtc->outputs);
RRModeDestroy(mode);
if (!ret)
@@ -1147,7 +1153,11 @@
Bool ret;
/* Let RandR know we approve, and let it update its internal state */
- ret = RRCrtcNotify(crtc, mode, x, y, rotation, num_outputs, outputs);
+ ret = RRCrtcNotify(crtc, mode, x, y, rotation,
+#if XORG >= 16
+ NULL,
+#endif
+ num_outputs, outputs);
if (!ret)
return FALSE;
@@ -1217,7 +1227,11 @@
RROutputSetConnection(output, RR_Connected);
/* Make sure the CRTC has this output set */
- RRCrtcNotify(crtc, NULL, 0, 0, RR_Rotate_0, 1, &output);
+ RRCrtcNotify(crtc, NULL, 0, 0, RR_Rotate_0,
+#if XORG >= 16
+ NULL,
+#endif
+ 1, &output);
/* Populate a list of default modes */
RRModePtr modes[sizeof(vncRandRWidths)/sizeof(*vncRandRWidths)];
@@ -1272,6 +1286,9 @@
return FALSE;
RRCrtcNotify(crtc, mode, 0, 0, RR_Rotate_0,
+#if XORG >= 16
+ NULL,
+#endif
crtc->numOutputs, crtc->outputs);
return TRUE;
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
