[
https://issues.apache.org/jira/browse/TIKA-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528984
]
Bertrand Delacretaz commented on TIKA-17:
-----------------------------------------
I have briefly reviewed your patch, looks good, thanks!
One question though:
1)
Index: src/main/java/org/apache/tika/config/LiusConfig.java
...
+ private static Document parse(URL url) {
...
- } catch (JDOMException jde) {
- logger.error(jde.getMessage(),jde);
- throw jde;
...
+ } catch (JDOMException e) {
+ logError(e, url);
...
Why did you delete the rethrowing of these Exceptions? Getting them here means
the resulting Document is unusable, so why not fail loudly with an Exception at
this point? By not doing it you'll probably get an unrelated Exception
elsewhere, which does not indicate what's really happening.
I won't apply the patch now, as Chris assigned this issue to himself.
Not also that if you supply an updated patch, it is better to re-upload it with
the same name - JIRA manages the obsolete versions just fine.
> Need to support URL's for input resources.
> ------------------------------------------
>
> Key: TIKA-17
> URL: https://issues.apache.org/jira/browse/TIKA-17
> Project: Tika
> Issue Type: Improvement
> Components: general
> Affects Versions: 0.1-incubator
> Reporter: Keith R. Bennett
> Assignee: Chris A. Mattmann
> Fix For: 0.1-incubator
>
> Attachments: tika-17-2.patch, tika-17.patch
>
>
> It would be extremely helpful to support URL's instead of just File's for
> input resources. This would enable us to use class loaders to find
> resources, and in general support resources that are not available via the
> filesystem.
> Patch coming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
