[
https://issues.apache.org/jira/browse/TIKA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530288
]
Keith R. Bennett commented on TIKA-29:
--------------------------------------
Jukka -
Do you mean my patch that contains the:
// Swallowed exception
comments? If so, no problem. The parsers were the bulk of the swallowed
exceptions anyway, and I think you got all of them. The file list above with
numbers of occurrences by file should be enough for someone to find them anyway.
I didn't intend for them to be committed anyway, just for illustrative
purposes. But if you want them committed, I can regenerate a patch.
Thanks,
Keith
> Exceptions are being swallowed that need to be thrown.
> ------------------------------------------------------
>
> Key: TIKA-29
> URL: https://issues.apache.org/jira/browse/TIKA-29
> Project: Tika
> Issue Type: Bug
> Components: general
> Affects Versions: 0.1-incubator
> Reporter: Keith R. Bennett
> Priority: Critical
> Fix For: 0.1-incubator
>
> Attachments: tika-29-diag.patch
>
>
> There are many cases in several classes where exceptions are being swallowed
> where they should be thrown instead.
> It is important that the caller be notified of an error if one occurs. The
> caller needs the opportunity to record the failure and set aside the document
> for future processing, or whatever else needs to be done in case of error.
> I'm marking this critical because we have no way of knowing the importance of
> the missing data; it could be of the utmost importance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
