[ 
https://issues.apache.org/jira/browse/TIKA-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532692
 ] 

Jukka Zitting commented on TIKA-41:
-----------------------------------

In any case you need some place where you define which resource ends up where 
in the final jar artifact. And I admit that there's little difference in 
whether that information is defined in a build script or encoded in the 
directory hierarchy. However, all other things equal, I think we should go with 
the conventions as codified by Maven, as that's what the average new 
user/developer will expect.

If you have a document that shouldn't go into the jar artifact, then by the 
Maven conventions you'd place it in src/test/resources (if it's needed for 
testing), src/site/resources (if it should go to the web site), or 
src/main/javadoc (if it should be a par t of the javadocs). I don't see why we 
should reinvent the wheel by maintaining our own build rules for such resources.

> So, anyways, I agree with one of your points, Jukka. The proposed method of 
> placing those config files within org/apache/tika
> is definitely the simplest solution: I'm just not sure it's the cleanest.

Fair enough. :-)

I don't feel too strongly on using the Maven conventions, so I won't mind if we 
do have the resources somewhere else. However, we should in any case fix the 
issue of having the resources duplicated in the jar artifact.

> Resource files occur twice in jar file.
> ---------------------------------------
>
>                 Key: TIKA-41
>                 URL: https://issues.apache.org/jira/browse/TIKA-41
>             Project: Tika
>          Issue Type: Improvement
>    Affects Versions: 0.1-incubator
>            Reporter: Keith R. Bennett
>            Priority: Minor
>             Fix For: 0.1-incubator
>
>
> The Tika and Mime config files occur in two places in the jar file.  This is 
> because they are not stored in our src/test/resources directory tree in the 
> same place that they need to be in the target/classes directory tree, and 
> there is a copy directive in the POM file that copies the files to different 
> directory.
> For example, tika-config.xml is in src/main/resources, but needs to go to 
> target/class/org/apache/tika.  Maven automatically copies the files in 
> src/main/resources to the same location in target/classes, so tika-config.xml 
> is copied to target/classes.  Then, the copy directive in the POM file copies 
> the file to target/classes/org/apache/tika.  So the file is copied twice.
> I recommend the following to fix this:
> * Move tika-config.xml to src/main/resources/org/apache/tika.
> * Move tika-mimetypes.xml to src/main/resources/org/apache/tika/mime.
> * Remove the copy directives for the above two from the POM file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to