[
https://issues.apache.org/jira/browse/TIKA-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583186#action_12583186
]
Jukka Zitting commented on TIKA-74:
-----------------------------------
Your patch contains too many unrelated changes, please focus only on the
specific issue at hand.
As for the getResource() method, it's a clear improvement, but I'm still not
perfectly happy with this. I don't think the test cases should assume that the
resources being loaded are actual files in the file system, and thus using
getResourceAsStream() would be more appropriate than constructing File
instances based on the URLs returned by getResource().
> Test Resources should be loaded by the class loader (e.g.
> getResourceAsStream()).
> ---------------------------------------------------------------------------------
>
> Key: TIKA-74
> URL: https://issues.apache.org/jira/browse/TIKA-74
> Project: Tika
> Issue Type: Improvement
> Components: general
> Affects Versions: 0.1-incubating
> Reporter: Keith R. Bennett
> Priority: Minor
> Fix For: 0.2-incubating
>
> Attachments: x.patch
>
>
> Resources should be loaded by the class loader rather than assumed to be a
> file in a certain location.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
