tchaikov left a comment (osm2pgsql-dev/osm2pgsql#2457)
> Can you please show how you have tested locally that your proposed change
> fixes the problem?
@lonvia hi Sarah, i tested it just by compiling it with fmt 12. see
https://copr.fedorainfracloud.org/coprs/tchaikov/fmt-12/build/10289308/ . I am
a maintainer of fmt library for fedora, so i need to fix all dependent packages
that fail to build when bumping the packaged fmt library in the distro i am
targeting. osm2pgsql is one of them. unfortunately, i don't use osm2pgsql
myself, and i don't have a pgsql db around to run the test suite against. but i
use COPR/Koji build environment runs the full test suite. see
https://download.copr.fedorainfracloud.org/results/tchaikov/fmt-12/fedora-rawhide-aarch64/10289349-osm2pgsql/builder-live.log
@joto i concur with you. so i've rewritten it to replicate the implementation
used by `fmt::localtime` -- including the exception raised by it. hopefully,
this would help to build more confidence to that this change is safe.
--
Reply to this email directly or view it on GitHub:
https://github.com/osm2pgsql-dev/osm2pgsql/pull/2457?email_source=notifications&email_token=AA6353SCXMBFOYQK72GPWWD4T53O5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJYGI2TSNRUG42KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS2XA4S7MNXW23LFNZ2F633QMVXF6Y3MNFRWW#issuecomment-4182596474
You are receiving this because you are subscribed to this thread.
Message ID: <osm2pgsql-dev/osm2pgsql/pull/2457/[email protected]>
_______________________________________________
Tile-serving mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/tile-serving
