@lonvia commented on this pull request.
> } else if (column.type() == table_column_type::id_num) {
+ if (id == 0) {
Isn't it safer to check for `objtype == osmium::item_type::undefined` here as
well? Just in case somebody works with zero IDs? (Or, in fact, just check for
`(!object)`.)
--
Reply to this email directly or view it on GitHub:
https://github.com/osm2pgsql-dev/osm2pgsql/pull/2491#pullrequestreview-4615335566
You are receiving this because you are subscribed to this thread.
Message ID: <osm2pgsql-dev/osm2pgsql/pull/2491/review/[email protected]>_______________________________________________
Tile-serving mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/tile-serving
