@joto commented on this pull request.


> +        CHECK(std::strcmp(node.tags()["name"], "Blue") == 0);
+    };
+
+    {
+        auto mid = std::make_shared<middle_pgsql_t>(thread_pool, &options);
+        mid->start();
+
+        mid->node(node10);
+        mid->after_nodes();
+        mid->after_ways();
+        mid->after_relations();
+
+        check(mid);
+    }
+
+    // From now on use append mode to not destroy the data we just added.

Is there a specific reason why you are running again here in append mode. It 
seems this doesn't have anything to do with the test we are doing here?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/osm2pgsql-dev/osm2pgsql/pull/2501#pullrequestreview-5316001718
You are receiving this because you are subscribed to this thread.

Message ID: <osm2pgsql-dev/osm2pgsql/pull/2501/review/[email protected]>
_______________________________________________
Tile-serving mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/tile-serving

Reply via email to