Makes the code build warning-free with `-Wall -Wextra`, including the flow-sensitive warnings GCC only reports at `-O2`/`-O3`. Together with the other PRs in this series, the code base builds with `-Werror` on GCC and Clang at every optimisation level.
- Signedness comparisons, unused variables, possibly-uninitialised locals, `void*` pointer arithmetic (a GNU extension), and the Apache module flags initialiser. - Tests: the stderr/stdout capture helpers returned buffers that weren't NUL-terminated (and used a VLA), ignored `pipe()`/`write()` failures, and used racy `std::tmpnam`, now replaced with a `mkstemp`-based helper. Independent of the other PRs in this series; it applies to `master` on its own and merges cleanly with each of them in any order. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01YForD7qSL9LT6FhMuAoKPV You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/mod_tile/pull/510 -- Commit Summary -- * Fix compiler warnings from -Wall -Wextra * Fix warnings that GCC only reports with optimisation enabled -- File Changes -- M src/mod_tile.c (11) M src/protocol_helper.c (8) M src/render_submit_queue.c (2) M src/renderd.c (4) M src/renderd_config.c (16) M tests/catch_test_common.cpp (34) M tests/gen_tile_test.cpp (18) M tests/renderd_config_test.cpp (48) -- Patch Links -- https://github.com/openstreetmap/mod_tile/pull/510.patch https://github.com/openstreetmap/mod_tile/pull/510.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/mod_tile/pull/510 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/mod_tile/pull/[email protected]>
_______________________________________________ Tile-serving mailing list [email protected] https://lists.openstreetmap.org/listinfo/tile-serving
