stevekennedyuk left a comment (openstreetmap/mod_tile#524)
Thanks for this! One follow-up for `store_ro_composite`: now that
`close_storage()` doesn't free the backend, `ro_composite_close_storage()`
needs to free its primary and secondary backends after closing them, or they
leak. While testing that I also found that its context is `malloc`'d, so
closing a composite store that has never read a tile `free()`s an uninitialised
`cache.tile` pointer and crashes. I've added fixes for both, plus composite
tests that catch them under ASan, to #504, which already reworks that function.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/mod_tile/pull/524#issuecomment-6337759709
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/mod_tile/pull/524/[email protected]>
_______________________________________________
Tile-serving mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/tile-serving
