Guys, I had to make a ton of noise, but fortunately OpenERP S.A. reverted it in commit [email protected]
Hopefully one day they start sorting out their internal code review process/hiring process and stop picturing themselves as the ultimate "quality authority" everybody should pay for. It's a bit tiring to see how much effort is required to get sanity refactoring get merged in the trunk versus how they can easily commit nonsense code internally, a bit far from how open source leads to quality... Also, concerning https://bugs.launchpad.net/openobject-addons/+bug/452854?comments=all I agree with Kaspar, this is absolutely not true that community comments where useless and only the OpenERP S.A. 2 lines patch fixes the issue. Olivier's comment at least forgot that: 1) only third party CampToCamp made a dedicated test framework (OERPScenario) + test case to prove the bug (OpenERP S.A. didn't even see it and didn't even have a decent test framework for that at this time and yet spent resource re-inventing a second one that still doesn't have all the advantages of OERScenario when it comes to readability and complex cross modules tests) 2) some rounding where hard coded to 0.01 no matter the pricing or accounting digit precision and only when we shoot about it it has been changed. 3) close to the end of the bug we where pretty sure the rounding issue with more than 2 digits where still there and we had to go patched for our ecommerce customer with the patch we long defended in details on the expert list. Disclaimer we didn't have time to test the very last patches. So finally, when you compare it to those facts all involved third party know, I find it a bit arrogant when OpenERP S.A. comes and say: > Just an example: bug 436449 you reported yourself, stayed open quite long, > the community was shouting that patches were provided and that we were doing > nothing (100+ comments!). > After careful investigation from our side it turned out that the proper fix > was a 2-lines patch and none of the proposed patches my $0.02 R$ ------------------------ Raphaël Valyi CEO and OpenERP consultant at http://www.akretion.com -------------------- m2f -------------------- -- http://www.openobject.com/forum/viewtopic.php?p=59624#59624 -------------------- m2f --------------------
_______________________________________________ Tinyerp-users mailing list http://tiny.be/mailman2/listinfo/tinyerp-users
