Hi,

I noticed TODO in tos/chips/atm128rfa1/radio/RFA1DriverLayerP.nc - line180: 
//TODO PA_EXT settings with defines

I am very interested about this feature. It would be very nice if external PA 
functionality can be switched on from Makefile.
It is also needed that PA_BUF_LT and PA_LT can be configured from Makefile.

Actually I have implemented half of the solution by myself by just adding this 
to serviceRadio():

      if( cmd == CMD_TURNON || cmd == CMD_CHANNEL )
      {
        RADIO_ASSERT( state == STATE_TRX_OFF_2_RX_ON );

        state = STATE_RX_ON;
        cmd = CMD_SIGNAL_DONE;

#ifdef ENABLE_PA        
        SET_BIT(TRX_CTRL_1, PA_EXT_EN);
#endif

Maybe it should be actually added to SoftwareInit.init(), however I had issues 
with it if application used serial or printf functionality. It did not worked 
because if serial was used then for some reason this SET_BIT(TRX_CTRL_1, 
PA_EXT_EN); did not give effect.
If application did not have serial everything worked as expected. I used 
https://github.com/phsommer/tinyos-main - have not tried yet with tinyos main 
trunk.

I see there is enum in RadioConfig.h with hardcoded values.
....
        RFA1_PA_BUF_LT=3<<PA_BUF_LT0,
        RFA1_PA_LT=0<<PA_LT0,
};

I guess more reasonable would be to use defines:

ifndef PA_BUF_LT
        define PA_BUF_LT 3

ifndef PA_LT
        define PA_LT 0


Miklos, maybe you have idea how to put it into main repository?
_______________________________________________
Tinyos-devel mailing list
[email protected]
https://www.millennium.berkeley.edu/cgi-bin/mailman/listinfo/tinyos-devel

Reply via email to