Hi Ying,
(Mail forwarded. For some reason some of your mails only show up in my private
mailbox, and not in Ericsson’s)
It basically goes like this:
tipc_rcv()
{
….
node_write_lock()
tipc_node_up(&xmitq1)
build_bcast_sync_msg(&xmitq1) //pkt #1
node_write_unlock()
named_node_up()
named_distribute(&xmitq2)
tipc_node_xmit(&xmitq2)
bearer_xmit(&xmitq2) //pkt #2
named_distribute(&xmitq2)
tipc_node_xmit(&xmitq2)
bearer_xmit(&xmitq2) //pkt #3
bearer_xmit(&xmitq1) //pkt #1
}
We could of course have fixed this by passing the same queue along everywhere,
but it is too intrusive for such a small problem.
///jon
From: Jon Maloy [mailto:ma...@donjonn.com]
Sent: Tuesday, 12 April, 2016 15:32
To: Jon Maloy
Subject: Tr : [PATCH net-next v2 4/5] tipc: ensure that first packets on link
are sent in order
----- Courriel transféré -----
De : "Xue, Ying" <ying....@windriver.com<mailto:ying....@windriver.com>>
À : Jon Maloy <jon.ma...@ericsson.com<mailto:jon.ma...@ericsson.com>>;
"tipc-discussion@lists.sourceforge.net<mailto:tipc-discussion@lists.sourceforge.net>"
<tipc-discussion@lists.sourceforge.net<mailto:tipc-discussion@lists.sourceforge.net>>;
"parthasarathy.bhuvara...@ericsson.com<mailto:parthasarathy.bhuvara...@ericsson.com>"
<parthasarathy.bhuvara...@ericsson.com<mailto:parthasarathy.bhuvara...@ericsson.com>>;
"richard.a...@ericsson.com<mailto:richard.a...@ericsson.com>"
<richard.a...@ericsson.com<mailto:richard.a...@ericsson.com>>
Cc : "ma...@donjonn.com<mailto:ma...@donjonn.com>"
<ma...@donjonn.com<mailto:ma...@donjonn.com>>
Envoyé le : mardi 12 avril 2016 6h47
Objet : RE: [PATCH net-next v2 4/5] tipc: ensure that first packets on link are
sent in order
Hi Jon,
Can you please explain a bit more what type of packets are disordered in link
establishment stage?
Thanks,
Ying
-----Original Message-----
From: Jon Maloy [mailto:jon.ma...@ericsson.com<mailto:jon.ma...@ericsson.com>]
Sent: 2016年4月11日 21:00
To:
tipc-discussion@lists.sourceforge.net<mailto:tipc-discussion@lists.sourceforge.net>;
parthasarathy.bhuvara...@ericsson.com<mailto:parthasarathy.bhuvara...@ericsson.com>;
Xue, Ying; richard.a...@ericsson.com<mailto:richard.a...@ericsson.com>;
jon.ma...@ericsson.com<mailto:jon.ma...@ericsson.com>
Cc: ma...@donjonn.com<mailto:ma...@donjonn.com>
Subject: [PATCH net-next v2 4/5] tipc: ensure that first packets on link are
sent in order
In some link establishment scenarios we see that packet #2 may be sent out
before packet #1, forcing the receiver to demand retransmission of the missing
packet. This is harmless, but may cause confusion among people tracing the
packet flow.
Since this is extremely easy to fix, we do so by adding en extra send call to
the bearer immediately after the link has come up.
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com<mailto:jon.ma...@ericsson.com>>
---
net/tipc/node.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/net/tipc/node.c b/net/tipc/node.c index ace178f..b00e12c 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -581,8 +581,12 @@ static void __tipc_node_link_up(struct tipc_node *n, int
bearer_id, static void tipc_node_link_up(struct tipc_node *n, int bearer_id,
struct sk_buff_head *xmitq)
{
+ struct tipc_media_addr *maddr;
+
tipc_node_write_lock(n);
__tipc_node_link_up(n, bearer_id, xmitq);
+ maddr = &n->links[bearer_id].maddr;
+ tipc_bearer_xmit(n->net, bearer_id, xmitq, maddr);
tipc_node_write_unlock(n);
}
--
1.9.1
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
tipc-discussion mailing list
tipc-discussion@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tipc-discussion
