Hi Partha,
1: Last line in help text is unaligned:
list - List links
get - Get various link properties
set - Set various link properties
statistics - Show or reset statistics
monitor - Show or set link supervision
root@xenial2:~# tipc/iproute2/tipc/tipc l m
2: It still took me a couple of attempts to find out how to list the
table contents.
If we only have one bearer, which is certainly the normal case, it
should not be necessary to indicate media and device.
For a novice this might be confusing, since he still has to go to
the man pages to find out how to indicate them.
Would that be hard to add?
3: I am not quite happy with the "domain_generation" header name. It is
very long, and pushes the node listing columns far out to the right. It
will look weird when you have many "non-applied" nodes. Maybe just call
it "generation" and explain in the man-pages (along with
"applied"/"non-applied") what it means?
Otherwise this looks very good.
///jon
On 07/13/2016 07:22 AM, Parthasarathy Bhuvaragan wrote:
> This commit series requires the following kernel patch set:
> "[PATCH net-next v3 0/5] tipc: netlink updates for neighbour monitor"
>
> v4: - Declare bname_list as constant in patch#2.
> - Declare media_list as global constant in patch#4.
> - Updated to address comments from Jon.M in patch 7, 9 & 10.
>
> v3: - simplified the header layouts in commit#9.
> - updated man pages.
>
> v2: - split patches into self-contained complete commits.
> - address review comments from richard alpe.
> - cleanup of tipc bearer.
> - introduce tipc link monitor summary
>
> regards
> Partha
>
> Parthasarathy Bhuvaragan (10):
> tipc: remove dead code
> tipc: introduce cmd_get_unique_bearer_name() function
> tipc: validate bearer arguments early
> tipc: fix bearer operations with media=ib
> tipc: add link monitor set threshold
> tipc: add link monitor get threshold
> tipc: add link monitor summary
> tipc: export some bearer helper functions
> tipc: add link monitor list
> tipc: update man page for link monitor
>
> include/linux/tipc_netlink.h | 37 ++++
> man/man8/tipc-link.8 | 105 +++++++++++
> tipc/bearer.c | 402
> ++++++++++++++++++++++++-------------------
> tipc/bearer.h | 3 +
> tipc/link.c | 383 ++++++++++++++++++++++++++++++++++++++++-
> 5 files changed, 745 insertions(+), 185 deletions(-)
>
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
_______________________________________________
tipc-discussion mailing list
tipc-discussion@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tipc-discussion
