On 07/28/2016 11:21 AM, Xue, Ying wrote:
> @@ -1642,7 +1673,6 @@ static bool filter_connect(struct tipc_sock *tsk, 
> struct sk_buff *skb)
>               msg_set_dest_droppable(hdr, 1);
>               return false;
>  
> -     case SS_LISTENING:
>
> I think we cannot simply ignore the case, instead we still need to deal with 
> the case when socket state is in SS_LISTENING. Otherwise, at least the below 
> sentence will be printed:
> " Unknown socket state -1"
But in this commit, a socket state can never be set to -1 (SS_LISTENING). If you
think it does, can you explain when does it happen?
>
> Regards,
> Ying
>
>       case SS_UNCONNECTED:
>  
>


------------------------------------------------------------------------------
_______________________________________________
tipc-discussion mailing list
tipc-discussion@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tipc-discussion

Reply via email to