Acknowledged. Thank you for doing this job. ///jon
> -----Original Message----- > From: Pan Bian [mailto:[email protected]] > Sent: Sunday, April 23, 2017 03:09 AM > To: Jon Maloy <[email protected]>; Ying Xue > <[email protected]>; David S. Miller <[email protected]> > Cc: [email protected]; [email protected]; linux- > [email protected]; Pan Bian <[email protected]> > Subject: [PATCH 1/1] tipc: check return value of nlmsg_new > > Function nlmsg_new() will return a NULL pointer if there is no enough > memory, and its return value should be checked before it is used. > However, in function tipc_nl_node_get_monitor(), the validation of the > return value of function nlmsg_new() is missed. This patch fixes the bug. > > Signed-off-by: Pan Bian <[email protected]> > --- > net/tipc/node.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/tipc/node.c b/net/tipc/node.c index 4512e83..568e48d 100644 > --- a/net/tipc/node.c > +++ b/net/tipc/node.c > @@ -2098,6 +2098,8 @@ int tipc_nl_node_get_monitor(struct sk_buff *skb, > struct genl_info *info) > int err; > > msg.skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL); > + if (!msg.skb) > + return -ENOMEM; > msg.portid = info->snd_portid; > msg.seq = info->snd_seq; > > -- > 1.9.1 > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tipc-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tipc-discussion
