Hi Dan, There is already a patch queued up for net-next fixing this. ///jon
> -----Original Message----- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Friday, January 12, 2018 15:49 > To: Jon Maloy <jon.ma...@ericsson.com> > Cc: tipc-discussion@lists.sourceforge.net > Subject: [bug report] tipc: send out join messages as soon as new member is > discovered > > Hello Jon Maloy, > > The patch d12d2e12cec2: "tipc: send out join messages as soon as new > member is discovered" from Jan 8, 2018, leads to the following static checker > warning: > > net/tipc/socket.c:2781 tipc_sk_join() > warn: passing freed memory 'grp' > > net/tipc/socket.c > 2771 seq.upper = seq.lower; > 2772 tipc_nametbl_build_group(net, grp, mreq->type, mreq->scope); > 2773 rc = tipc_sk_publish(tsk, mreq->scope, &seq); > 2774 if (rc) { > 2775 tipc_group_delete(net, grp); > ^^^ Freed. > > 2776 tsk->group = NULL; > 2777 } > 2778 /* Eliminate any risk that a broadcast overtakes sent JOINs */ > 2779 tsk->mc_method.rcast = true; > 2780 tsk->mc_method.mandatory = true; > 2781 tipc_group_join(net, grp, &tsk->sk.sk_rcvbuf); > ^^^ Re-used > > 2782 return rc; > 2783 } > > regards, > dan carpenter ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tipc-discussion mailing list tipc-discussion@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tipc-discussion
