From: Jon Maloy <[email protected]> Date: Thu, 8 Feb 2018 17:16:25 +0100
> From: Hoang Le <[email protected]> > > In commit d618d09a68e4 ("tipc: enforce valid ratio between skb truesize > and contents") we introduced a test for ensuring that the condition > truesize/datasize <= 4 is true for a received buffer. Unfortunately this > test has two problems. > > - Because of the integer arithmetics the test > if (skb->truesize / buf_roundup_len(skb) > 4) will miss all > ratios [4 < ratio < 5], which was not the intention. > - The buffer returned by skb_copy() inherits skb->truesize of the > original buffer, which doesn't help the situation at all. > > In this commit, we change the ratio condition and replace skb_copy() > with a call to skb_copy_expand() to finally get this right. > > Acked-by: Jon Maloy <[email protected]> > Signed-off-by: Jon Maloy <[email protected]> Applied, thanks Jon. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tipc-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tipc-discussion
