A not totally unexpected response, unfortunately. I don't agree with David, but I am not going to fight him on this. And, as he pointed out we can achieve almost the same by using SO_RCVBUF/SOL_SOCKET. We only need to configure the /proc/sys/net/core/rmem_max to the same as tipc_rmem_max or bigger. This has the advantage that we don't need to change the default value, and we avoid side effect on other protocols.
///jon > -----Original Message----- > From: David Miller [mailto:[email protected]] > Sent: Wednesday, February 28, 2018 11:36 > To: Jon Maloy <[email protected]> > Cc: [email protected]; Mohan Krishna Ghanta Krishnamurthy > <[email protected]>; Tung Quang Nguyen > <[email protected]>; Hoang Huu Le > <[email protected]>; Canh Duc Luu > <[email protected]>; Ying Xue <[email protected]>; tipc- > [email protected] > Subject: Re: [net-next 1/1] tipc: sockopt(TIPC_SO_RCVBUF) for setting > receive buffer > > From: Jon Maloy <[email protected]> > Date: Tue, 27 Feb 2018 20:47:09 +0100 > > > From: Hoang Le <[email protected]> > > > > We introduce a set/getsockopt for setting socket receive buffer per > > individual socket. This has turned out to sometimes be necessary for > > anycast and multicast receivers when used without flow control. > > > > Signed-off-by: Hoang Le <[email protected]> > > Signed-off-by: Jon Maloy <[email protected]> > > I really don't want things to start going down this road. > > The semantics for foo_rmem[] is that the [1] value indicates the default on a > new socket, and [2] determines how large > sk->sk_rcvbuf will grow through automatic receive buffer > autosizing as done by TCP. > > It is not a limit value to impose upon the user's request. > > Furthermore, the user can just do a SO_RCVBUF setsockopt to bypass these > limits. > > So this change is undesirable on many levels. > > I'm not applying this, sorry. Please get TIPC sockets to behave and enforce > limits just like other socket families do, avoid custom family specific > behavior > at all costs. > > Thank you. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tipc-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tipc-discussion
