The series look good to me, so if you make the changes I suggested you can set all commits as acked by me.
BR ///jon > -----Original Message----- > From: Mohan Krishna Ghanta Krishnamurthy > Sent: Tuesday, March 13, 2018 11:20 > To: [email protected]; Jon Maloy > <[email protected]>; [email protected]; Ying Xue > <[email protected]> > Subject: [net-next 0/3] tipc: socket diagnostics additions for AF_TIPC > > The following patchsets add socket diagnostics support for AF_TIPC by using > the sock diag framework. The patchset was created on top of commit id: > fb66cb0. > > New iproute2 package is needed to use this functionality which will be sent > for review in a seperate mail. > > The commit series improves diagnosis of tipc sockets by exporting the > configuration, states and statistics of sockets. > > The series has been co-authored by Parthasarathy Bhuvaragan and consist of > two parts: > > 1-2: Adaptations of existing code to support sock_diag framework. > We modify existing functions to support socket diagnostics. Required > information about the sockets are exported. > > 3: Step sk_drops during packet drop. > This occurs if the packet cannot be queued due to queue length exceeding > configured thresholds. > > The diag module is optional, and if enabled it will be loaded on demand when > needed. > > GhantaKrishnamurthy MohanKrishna (3): > tipc: modify socket iterator for sock_diag > tipc: implement socket diagnostics for AF_TIPC > tipc: step sk->sk_drops when rcv buffer is full > > include/uapi/linux/tipc_netlink.h | 19 +++++ > include/uapi/linux/tipc_sockets_diag.h | 17 +++++ > net/tipc/Kconfig | 8 ++ > net/tipc/Makefile | 5 ++ > net/tipc/diag.c | 114 ++++++++++++++++++++++++++++ > net/tipc/socket.c | 132 > +++++++++++++++++++++++++++------ > net/tipc/socket.h | 10 ++- > 7 files changed, 280 insertions(+), 25 deletions(-) create mode 100644 > include/uapi/linux/tipc_sockets_diag.h > create mode 100644 net/tipc/diag.c > > -- > 2.1.4 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tipc-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tipc-discussion
