Hi Ying, Jon Could you please take time to review the patch. I'd like to merge the fix into iproute2, otherwise our Jenkins jobs always get failure on using 'tipc' tool.
Thanks, Hoang -----Original Message----- From: Hoang Le <[email protected]> Sent: Friday, May 25, 2018 1:08 PM To: [email protected]; [email protected]; [email protected]; [email protected] Subject: [tipc-discussion] [iproute2 1/1] tipc: TIPC_NLA_LINK_NAME value pass on nesting entry TIPC_NLA_LINK In the commit 94f6a80 on next-net, TIPC_NLA_LINK_NAME attribute should be retrieved and validated via TIPC_NLA_LINK nesting entry in tipc_nl_node_get_link(). According to that commit, TIPC_NLA_LINK_NAME value passing via tipc link get command must follow above hierachy. Signed-off-by: Hoang Le <[email protected]> --- tipc/link.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tipc/link.c b/tipc/link.c index 02f14aadefa6..a2d7c0016bc1 100644 --- a/tipc/link.c +++ b/tipc/link.c @@ -97,6 +97,7 @@ static int cmd_link_get_prop(struct nlmsghdr *nlh, const struct cmd *cmd, { int prop; char buf[MNL_SOCKET_BUFFER_SIZE]; + struct nlattr *attrs; struct opt *opt; struct opt opts[] = { { "link", OPT_KEYVAL, NULL }, @@ -131,7 +132,9 @@ static int cmd_link_get_prop(struct nlmsghdr *nlh, const struct cmd *cmd, fprintf(stderr, "error, missing link\n"); return -EINVAL; } + attrs = mnl_attr_nest_start(nlh, TIPC_NLA_LINK); mnl_attr_put_strz(nlh, TIPC_NLA_LINK_NAME, opt->val); + mnl_attr_nest_end(nlh, attrs); return msg_doit(nlh, link_get_cb, &prop); } -- 2.1.4 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tipc-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tipc-discussion ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tipc-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tipc-discussion
