Your series is good to me.
Acked-by: Ying Xue <[email protected]> On 12/18/18 6:11 PM, Tuong Lien wrote: > The patch series is the first step of introducing a tracing framework in > TIPC, which will assist in collecting complete & plentiful data for post > analysis, even in the case of a single failure occurrence e.g. when the > failure is unreproducible. > > The tracing code in TIPC utilizes the powerful kernel tracepoints, trace > events features along with particular dump functions to trace the TIPC > object data and events (incl. bearer, link, socket, node, etc.). > > The tracing code should generate zero-load to TIPC when the trace events > are not enabled. > > v2: improve trace output format; > improve the socket traces, make it now convenient for user to do the > socket traces on any specific socket when needed (by using the new > sysctl file - '/proc/sys/net/tipc/sk_filter' with a socket 'tuple' > for filtering); > add a new dump option for link's wakeup queue, add trace for link > congestion situation; > improve the node and bearer traces; > > Tuong Lien (5): > tipc: enable tracepoints in tipc > tipc: add trace_events for tipc link > tipc: add trace_events for tipc socket > tipc: add trace_events for tipc node > tipc: add trace_events for tipc bearer > > net/tipc/Makefile | 4 +- > net/tipc/bearer.c | 9 +- > net/tipc/bearer.h | 2 +- > net/tipc/link.c | 153 ++++++++++++++++++- > net/tipc/link.h | 2 + > net/tipc/node.c | 88 ++++++++++- > net/tipc/node.h | 1 + > net/tipc/socket.c | 230 ++++++++++++++++++++++++++++- > net/tipc/socket.h | 4 + > net/tipc/sysctl.c | 8 + > net/tipc/trace.c | 206 ++++++++++++++++++++++++++ > net/tipc/trace.h | 431 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 12 files changed, 1122 insertions(+), 16 deletions(-) > create mode 100644 net/tipc/trace.c > create mode 100644 net/tipc/trace.h > _______________________________________________ tipc-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tipc-discussion
