> -----Original Message-----
> From: [email protected] <[email protected]>
> On Behalf Of Arnd Bergmann
> Sent: 21-Mar-19 19:23
> To: Jon Maloy <[email protected]>
> Cc: Nick Desaulniers <[email protected]>; Nathan Chancellor
> <[email protected]>; Ying Xue <[email protected]>; David S.
> Miller <[email protected]>; [email protected];
> Networking <[email protected]>; LKML <linux-
> [email protected]>; [email protected]
> Subject: Re: -Wsometimes-uninitialized Clang warning in net/tipc/node.c
>
> On Thu, Mar 21, 2019 at 4:25 PM Arnd Bergmann <[email protected]> wrote:
> >
> > On Thu, Mar 21, 2019 at 3:57 PM Jon Maloy <[email protected]>
> wrote:
>
> > > >
> > > > diff --git a/net/tipc/node.c b/net/tipc/node.c index
> > > > 2dc4919ab23c..147786795e48 100644
> > > > --- a/net/tipc/node.c
> > > > +++ b/net/tipc/node.c
> > > > @@ -844,7 +844,8 @@ static void tipc_node_link_down(struct
> > > > tipc_node *n, int bearer_id, bool delete)
> > > > tipc_node_write_unlock(n);
> > > > if (delete)
> > > > tipc_mon_remove_peer(n->net, n->addr, old_bearer_id);
> > > > - tipc_bearer_xmit(n->net, bearer_id, &xmitq, maddr);
> > > > + if (skb_queue_empty(xmitq))
> > > > + tipc_bearer_xmit(n->net, bearer_id, &xmitq,
> > > > + maddr);
> > > > tipc_sk_rcv(n->net, &le->inputq); }
> > > >
> > > > This duplicates the check inside of skb_queue_empty(), but I don't
> > > > know if the compiler can see through the logic behind the inlined
> function calls.
> > >
> > > Probably not, but this is not in any way time critical.
> >
> > I meant it's unclear whether compilers should be expected to see that
> > skb_queue_empty() is true after the call to __skb_queue_head_init()
> > initializes it.
>
> I reproduced the warning now, and verified that my change eliminates the
> warning. I still think that is the more logical solution here.
Ok. No problems with that.
///jon
>
> Arnd
_______________________________________________
tipc-discussion mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tipc-discussion
