I can recognize this is a good improvement except that the following switch
cases of return values of tipc_msg_try_bundle() are not very friendly for code
reader. Although I do understand their real meanings, I have to spend time
checking its context back and forth. At least we should the meaningless hard
code case numbers or we try to change return value numbers of
tipc_msg_try_bundle().
+ n = tipc_msg_try_bundle(&l->backlog[imp].target_bskb, skb,
+ mtu - INT_H_SIZE,
+ l->addr);
+ switch (n) {
+ case 0:
+ break;
+ case 1:
+ __skb_queue_tail(backlogq, skb);
l->backlog[imp].len++;
- l->stats.sent_bundled++;
+ continue;
+ case 2:
l->stats.sent_bundles++;
+ l->stats.sent_bundled++;
+ default:
+ kfree_skb(skb);
+ l->stats.sent_bundled++;
continue;
_______________________________________________
tipc-discussion mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tipc-discussion
