On 2/24/21 8:55 AM, Xin Long wrote:
Hi Jon,
Sorry for so late to check this patchset, I just came back from
Chinese New Year holidays.
Overall I like the idea to use one or two new structures to make the
parameters passing between functions more clear and readable.
Meanwhile I think if the parameters of some function are already
simple, we may just need to pass what the function only wants. After
all, ua->xxx will need CPU to access memory obj instead of read
registers only, and we will have to build a ua object before calling
the function.
I see your point. The plan is that struct tipc_uaddr later will contain
two very different address types, and we want to hide that as much as
possible in the parts of the code where this is not relevant. We can see
later, when all is done, if there are optimizations that can be done.
///jon
I just commented on some of the patches.
Thanks.
On Wed, Dec 9, 2020 at 2:51 AM <jma...@redhat.com> wrote:
From: Jon Maloy <jma...@redhat.com>
We make a number of simplifications and cleanups, especially to call signatures
in the binding table. This makes the code easier to understand and serves as a
preparation for an upcoming functional addition.
Jon Maloy (16):
tipc: re-organize members of struct publication
tipc: move creation of publication item one level up in call chain
tipc: introduce new unified address type for internal use
tipc: simplify signature of tipc_namtbl_publish()
tipc: simplify call signatures for publication creation
tipc: simplify signature of tipc_nametbl_withdraw() functions
tipc: rename binding table lookup functions
tipc: refactor tipc_sendmsg() and tipc_lookup_anycast()
tipc: simplify signature of tipc_namtbl_lookup_mcast_sockets()
tipc: simplify signature of tipc_nametbl_lookup_mcast_nodes()
tipc: simplify signature of tipc_nametbl_lookup_group()
tipc: simplify signature of tipc_service_find_range()
tipc: simplify signature of tipc_find_service()
tipc: simplify api between binding table and topology server
tipc: add host-endian copy of user subscription to struct
tipc_subscription
tipc: remove some unnecessary warnings
net/tipc/addr.h | 44 +++++
net/tipc/msg.c | 23 ++-
net/tipc/name_distr.c | 89 +++++----
net/tipc/name_table.c | 419 ++++++++++++++++++++++--------------------
net/tipc/name_table.h | 64 ++++---
net/tipc/net.c | 8 +-
net/tipc/node.c | 28 +--
net/tipc/socket.c | 313 +++++++++++++++----------------
net/tipc/subscr.c | 84 +++++----
net/tipc/subscr.h | 12 +-
10 files changed, 567 insertions(+), 517 deletions(-)
--
2.28.0
_______________________________________________
tipc-discussion mailing list
tipc-discussion@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tipc-discussion
_______________________________________________
tipc-discussion mailing list
tipc-discussion@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tipc-discussion
