On 3/18/2022 11:58 AM, Hoang Le wrote: > In the timer callback function tipc_sk_timeout(), we're trying to > reschedule another timeout to retransmit a setup request if destination > link is congested. But we use the incorrect timeout value > (msecs_to_jiffies(100)) instead of (jiffies + msecs_to_jiffies(100)), > so that the timer expires immediately, it's irrelevant for original > description. > > In this commit we correct the timeout value in sk_reset_timer() > > Fixes: 6787927475e5 ("tipc: buffer overflow handling in listener socket") > Signed-off-by: Hoang Le <hoang.h...@dektech.com.au>
Acked-by: Ying Xue <ying....@windriver.com> > --- > net/tipc/socket.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/tipc/socket.c b/net/tipc/socket.c > index 7545321c3440..17f8c523e33b 100644 > --- a/net/tipc/socket.c > +++ b/net/tipc/socket.c > @@ -2852,7 +2852,8 @@ static void tipc_sk_retry_connect(struct sock *sk, > struct sk_buff_head *list) > > /* Try again later if dest link is congested */ > if (tsk->cong_link_cnt) { > - sk_reset_timer(sk, &sk->sk_timer, msecs_to_jiffies(100)); > + sk_reset_timer(sk, &sk->sk_timer, > + jiffies + msecs_to_jiffies(100)); > return; > } > /* Prepare SYN for retransmit */ _______________________________________________ tipc-discussion mailing list tipc-discussion@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tipc-discussion