>Subject: [PATCH v1] tipc: resize nlattr array to correct size > >According to nla_parse_nested_deprecated(), the tb[] is supposed to the >destination array with maxtype+1 elements. In current >tipc_nl_media_get() and __tipc_nl_media_set(), a larger array is used >which is unnecessary. This patch resize them to a proper size. > >Signed-off-by: Lin Ma <li...@zju.edu.cn> >---
Which branch (net or net-next) do you want to apply this change to ? > net/tipc/bearer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c >index 53881406e200..cdcd2731860b 100644 >--- a/net/tipc/bearer.c >+++ b/net/tipc/bearer.c >@@ -1258,7 +1258,7 @@ int tipc_nl_media_get(struct sk_buff *skb, struct >genl_info *info) > struct tipc_nl_msg msg; > struct tipc_media *media; > struct sk_buff *rep; >- struct nlattr *attrs[TIPC_NLA_BEARER_MAX + 1]; >+ struct nlattr *attrs[TIPC_NLA_MEDIA_MAX + 1]; > > if (!info->attrs[TIPC_NLA_MEDIA]) > return -EINVAL; >@@ -1307,7 +1307,7 @@ int __tipc_nl_media_set(struct sk_buff *skb, struct >genl_info *info) > int err; > char *name; > struct tipc_media *m; >- struct nlattr *attrs[TIPC_NLA_BEARER_MAX + 1]; >+ struct nlattr *attrs[TIPC_NLA_MEDIA_MAX + 1]; > > if (!info->attrs[TIPC_NLA_MEDIA]) > return -EINVAL; >-- >2.17.1 > _______________________________________________ tipc-discussion mailing list tipc-discussion@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tipc-discussion
