Hi
Thanks. Sorry for the delay... A few more comments:
- I don't like the iteration in tty_upgrade_colour, it would be better
just to have colourmap be just two fixed size arrays (one for fg, one
for bg). Then you could lose the fg16 and bg16 members.
- I think a flag to map-colour might be better than four arguments and a
wildcard. So maybe -f for fg and -b for bg, eg:
map-colour 1 100 <-- map fg 1 to 100
map-colour -f 1 100 <-- same
map-colour -b 2 200 <-- map bg 2 to 200
- I think reset-colours shouldn't be a new command, it should be
a flag to map-colour - maybe map-colour -R should reset.
- You need to check errstr == NULL from strtonum to see if succeeded.
- What does the "c->fg16 = 7; c->bg16=0; c->fg256=143; c->bg256=113;"
bit of the comment in cmd_map_colour_exec mean?
- No C++/C99-style // comments please.
- Indentation and spacing in tty_upgrade_colour looks pretty funky.
- "if (gc->flags & (GRID_FLAG_FG256 || GRID_FLAG_BG256))" <-- this "||"
should probably be just "|".
- cmd_table should be sorted.
On Mon, Dec 26, 2011 at 08:44:59PM +0100, Benjamin Schweizer wrote:
> Hello Nicholas,
>
> I've fixed tabs, licensing and updated the man page.
>
> A new patch created against the subversion tree is here:
>
> ****** [1]http://benjamin-schweizer.de/files/tmux/tmux-colourmap2.diff
>
> Let me know if it needs more clearing up.
>
> btw: I've heard more complaints about the broken tarball, but it looks ok
> on my Debian-stable machine.
>
> regards,
>
> On Sat, Dec 24, 2011 at 9:48 AM, Nicholas Marriott
> <[2]nicholas.marri...@gmail.com> wrote:
>
> Hi
>
> Thanks.
>
> It looks like you managed to somehow gzip your .tar.gz twice...
>
> Can you send this as a unified diff against the source rather than a set
> of files?
>
> To do this, either checkout the Subversion source from SourceForge,
> modify it (in trunk/) and do "svn diff" (after using "svn add" on new
> files). You'll have to run sh autoconf.sh to generate the infrastructure
> (such as configure) needed for building.
>
> If you prefer to work on 1.5, copy your tmux 1.5 directory entire to eg
> tmux.orig, make your changes in previous tmux directory, then do make
> clean distclean and do:
>
> $ diff -rNup tmux.orig tmux >tmux.diff
>
> It's usually easier all round if you make the changes against the latest
> Subversion source.
>
> On the face of it, I'm not unhappy with the idea but your code will need
> a little tidying up, for example please use 8 character tabs rather than
> spaces. It'll also need a manpage change.
>
> Please use the full ISC license in the other files for your new
> cmd-map-colour.c and be more specific than "copyleft" about the license
> for the themes files. If you want them to be included as well this means
> explicitly saying public domain (see examples/), or the ISC license used
> elsewhere.
>
> On Fri, Dec 23, 2011 at 10:53:21AM +0100, Benjamin Schweizer wrote:
> > ** **Hello,
> >
> > ** **I've created a patch for mapping colors from 16 color palettes to
> 256
> > ** **colors.
> > ** **This is usefull if you want to modernize old software with fixed
> color
> > ** **palettes, e.g. irssi or midnight commander.
> >
> > ** **Here's a blog post with screenshots:
> > **
>
> **[1][3]http://benjamin-schweizer.de/colorful-terminals-theme-support-for-tmux.html
> >
> > ** **Here's a sample theme:
> > **
>
> **[2][4]http://benjamin-schweizer.de/files/tmux/tmux-themes/sundevil.tmux.conf
> >
> > ** **Here's a link to the source code:
> > ** **[3][5]http://benjamin-schweizer.de/files/tmux/
> >
> > ** **What's your opinion on this?
> > ** **How can I get this included in upstream CVS?
> >
> > ** **Greetings,
> >
> > ** **--
> > ** **[4][6]http://benjamin-schweizer.de/contact
> >
> > References
> >
> > ** **Visible links
> > ** **1.
>
> [7]http://benjamin-schweizer.de/colorful-terminals-theme-support-for-tmux.html
> > ** **2.
> [8]http://benjamin-schweizer.de/files/tmux/tmux-themes/sundevil.tmux.conf
> > ** **3. [9]http://benjamin-schweizer.de/files/tmux/
> > ** **4. [10]http://benjamin-schweizer.de/contact
>
> >
>
> ------------------------------------------------------------------------------
> > Write once. Port to many.
> > Get the SDK and tools to simplify cross-platform app development.
> Create
> > new or port existing apps to sell to consumers worldwide. Explore the
> > Intel AppUpSM program developer opportunity.
> [11]appdeveloper.intel.com/join
> > [12]http://p.sf.net/sfu/intel-appdev
>
> > _______________________________________________
> > tmux-users mailing list
> > [13]tmux-users@lists.sourceforge.net
> > [14]https://lists.sourceforge.net/lists/listinfo/tmux-users
>
> --
> [15]http://benjamin-schweizer.de/contact
>
> References
>
> Visible links
> 1. http://benjamin-schweizer.de/files/tmux/tmux-colourmap2.diff
> 2. mailto:nicholas.marri...@gmail.com
> 3.
> http://benjamin-schweizer.de/colorful-terminals-theme-support-for-tmux.html
> 4. http://benjamin-schweizer.de/files/tmux/tmux-themes/sundevil.tmux.conf
> 5. http://benjamin-schweizer.de/files/tmux/
> 6. http://benjamin-schweizer.de/contact
> 7.
> http://benjamin-schweizer.de/colorful-terminals-theme-support-for-tmux.html
> 8. http://benjamin-schweizer.de/files/tmux/tmux-themes/sundevil.tmux.conf
> 9. http://benjamin-schweizer.de/files/tmux/
> 10. http://benjamin-schweizer.de/contact
> 11. http://appdeveloper.intel.com/join
> 12. http://p.sf.net/sfu/intel-appdev
> 13. mailto:tmux-users@lists.sourceforge.net
> 14. https://lists.sourceforge.net/lists/listinfo/tmux-users
> 15. http://benjamin-schweizer.de/contact
------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual
desktops for less than the cost of PCs and save 60% on VDI infrastructure
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users
