On Sun, Oct 27, 2013 at 11:37:02PM +0100, Marcel Partap wrote:
> Rename
> screen_redraw_cell_border1() => screen_redraw_get_border_rel()
> screen_redraw_cell_border() => screen_redraw_cell_is_border()
> screen_redraw_check_cell() => screen_redraw_get_cell_type()
> screen_redraw_check_active() => screen_redraw_check_active_pane_indicator()
As Nicholas has mentioned, this does much more than just rename some
functions, and neither does this, nor any of the other three patches you've
sent through, indicate any rationale for this change.
IIRC from an earlier round, these patches were designed to somehow "better"
indicate which pane has the focus? If that's true, we still have the
split-pane colourisation thing which seems to do this, albeit perhaps not as
intuitively.
I am not personally too keen on this change to introduce such indicators
beyond what we have right now in tmux. I'm in progress for reviewing a
patch to add pane labels, if/when that's merged to tmux, this could be
expanded with tmux formats to style these pane labels to do the job of your
patches.
But I am not convinced these patches do the right thing.
-- Thomas Adam
--
"Deep in my heart I wish I was wrong. But deep in my heart I know I am
not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.)
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users
