Hi I'm more inclined to think that it's more flexible to just do one thing, as well as not changing long-standing behaviour.
How are you using select-pane? If you are binding it to command-prompt, can't you just bind selectw\; selectp? We could potentially add a flag to selectp. On Thu, Jun 19, 2014 at 09:21:11AM +0100, George Brown wrote: > Hi, > I hadn't looked at it from a session basis. My train of thought was this > patch provides more consistent behaviour of select-pane in that it always > switches to the pane you select. I'm not sure of the use case of being > able to select a different pane outside the current window but not switch > to it. Do others find a use for this? For me if I am selecting a pane I > always want to move to it regardless if it exists in my current window or > not. > Kind regards, > George > George Brown > > On 19 June 2014 08:47, Nicholas Marriott <[1]nicholas.marri...@gmail.com> > wrote: > > I'm not sure it does make more sense. select-window doesn't change the > session, so why should select-pane change the window? > > On Thu, Jun 19, 2014 at 08:42:33AM +0100, George Brown wrote: > > ** **Dear all, > > ** **Thanks for this patch Thomas it works for me, I applied against > what was > > ** **currently in git to build and it behaves exactly as I would > expect. I'd > > ** **love to see this mainlined and think this behaviour makes far > more sense > > ** **than the current release. > > ** **Many thanks, > > ** **George > > ** **George Brown > > > > ** **On 18 June 2014 16:43, Thomas Adam <[1][2]tho...@xteddy.org> > wrote: > > > > ** ** **On 18 June 2014 16:09, George Brown > <[2][3]321.geo...@gmail.com> wrote: > > ** ** **> Dear all, > > ** ** **> > > ** ** **> I was attempting this today and realised the "tmux > select-pane" only > > ** ** **> switches to panes in the active window. It appear this was > raised in > > ** ** **the > > ** ** **> following ticket but I have not been able to find the actual > > ** ** **discussion or > > ** ** **> mentioned patch. > > ** ** **> > > ** ** **> [3][4]http://sourceforge.net/p/tmux/tickets/98/ > > ** ** **> > > ** ** **> I am running 1.9a and would love to test the patch if > someone could > > ** ** **point me > > ** ** **> to it. > > > > ** ** **This was what I had originally: > > > > ** ** **diff --git a/cmd-select-pane.c b/cmd-select-pane.c > > ** ** **index 1a1072d..f989182 100644 > > ** ** **--- a/cmd-select-pane.c > > ** ** **+++ b/cmd-select-pane.c > > ** ** **@@ -67,6 +67,7 @@ cmd_select_pane_exec(struct cmd *self, > struct cmd_q > > ** ** ***cmdq) > > ** ** **** ** ** ** struct args ** ** ** ** ** ** *args = self->args; > > ** ** **** ** ** ** struct winlink ** ** ** ** ***wl; > > ** ** **** ** ** ** struct window_pane ** ** ***wp; > > ** ** **+ ** ** ** struct session ** ** ** ** ***s; > > > > ** ** **** ** ** ** if (self->entry == &cmd_last_pane_entry || > args_has(args, > > ** ** **'l')) { > > ** ** **** ** ** ** ** ** ** ** wl = cmd_find_window(cmdq, > args_get(args, 't'), > > ** ** **NULL); > > ** ** **@@ -86,7 +87,7 @@ cmd_select_pane_exec(struct cmd *self, > struct cmd_q > > ** ** ***cmdq) > > ** ** **** ** ** ** ** ** ** ** return (CMD_RETURN_NORMAL); > > ** ** **** ** ** ** } > > > > ** ** **- ** ** ** if ((wl = cmd_find_pane(cmdq, args_get(args, 't'), > NULL, > > ** ** **&wp)) == NULL) > > ** ** **+ ** ** ** if ((wl = cmd_find_pane(cmdq, args_get(args, 't'), > &s, &wp)) > > ** ** **== NULL) > > ** ** **** ** ** ** ** ** ** ** return (CMD_RETURN_ERROR); > > > > ** ** **** ** ** ** server_unzoom_window(wp->window); > > ** ** **@@ -111,6 +112,8 @@ cmd_select_pane_exec(struct cmd *self, > struct cmd_q > > ** ** ***cmdq) > > ** ** **** ** ** ** window_set_active_pane(wl->window, wp); > > ** ** **** ** ** ** server_status_window(wl->window); > > ** ** **** ** ** ** server_redraw_window_borders(wl->window); > > ** ** **+ ** ** ** if (session_select(s, wl->idx) == 0) > > ** ** **+ ** ** ** ** ** ** ** server_redraw_session(s); > > > > ** ** **** ** ** ** return (CMD_RETURN_NORMAL); > > ** ** ****} > > > > ** ** **It should still work. > > ** ** **-- Thomas Adam > > > > References > > > > ** **Visible links > > ** **1. mailto:[5]tho...@xteddy.org > > ** **2. mailto:[6]321.geo...@gmail.com > > ** **3. [7]http://sourceforge.net/p/tmux/tickets/98/ > > > > > ------------------------------------------------------------------------------ > > HPCC Systems Open Source Big Data Platform from LexisNexis Risk > Solutions > > Find What Matters Most in Your Big Data with HPCC Systems > > Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. > > Leverages Graph Analysis for Fast Processing & Easy Data Exploration > > [8]http://p.sf.net/sfu/hpccsystems > > > _______________________________________________ > > tmux-users mailing list > > [9]tmux-users@lists.sourceforge.net > > [10]https://lists.sourceforge.net/lists/listinfo/tmux-users > > References > > Visible links > 1. mailto:nicholas.marri...@gmail.com > 2. mailto:tho...@xteddy.org > 3. mailto:321.geo...@gmail.com > 4. http://sourceforge.net/p/tmux/tickets/98/ > 5. mailto:tho...@xteddy.org > 6. mailto:321.geo...@gmail.com > 7. http://sourceforge.net/p/tmux/tickets/98/ > 8. http://p.sf.net/sfu/hpccsystems > 9. mailto:tmux-users@lists.sourceforge.net > 10. https://lists.sourceforge.net/lists/listinfo/tmux-users > ------------------------------------------------------------------------------ > HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions > Find What Matters Most in Your Big Data with HPCC Systems > Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. > Leverages Graph Analysis for Fast Processing & Easy Data Exploration > http://p.sf.net/sfu/hpccsystems > _______________________________________________ > tmux-users mailing list > tmux-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/tmux-users ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
