On Sun, Feb 22, 2015 at 01:45:38AM -0600, J Raynor wrote: > > You can try to make tmux itself support BCE ... or add BCE support > > back on top of this like you had before. > > I don't know how to make tmux support terminals without BCE besides > what I already did. Can you give me some detail for what you mean by > "make tmux itself support BCE"?
It needs to handle three cases: 1) Drawing something new from an application on a BCE terminal. This is handled by the tty_attributes changes for tty_cmd_* in the pane colour diff, except it will need to use the tty->cell bg colour not the default bg colour. 2) Drawing something new from an application on a non-BCE terminal. This is the BCE bits you did before. 3) Redrawing an existing line from the grid. When tmux does an erase, it will need to use the background colour for the grid if it is not default, so that tty_draw_line redraws it correctly. This will mostly mean changing grid_clear_* and possibly grid_move_* (not sure what BCE terminals do there, will need to test) to take a grid_cell for the bg colour and fill it in instead of grid_default_cell. It would be best if as much as possible it preserves the ability for tmux to issue EL to erase a line in tty_draw_line rather than forcing it to always draw the whole lot with spaces. So it may mean generating lines that are just a single space long in, for example, grid_clear and grid_clear_lines. Then tty_draw_line will also need to change so that the EL bit at the end uses the last set colour, but if we can guarantee lines will always either all default bg or at least 1 char long, that should be simple. ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk _______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
