Hi Dave,

I've reviewed the spreadsheet. There is only one problem as far as I can
see: the package size information in the included packages and built
packages tables is no longer right-aligned (it used to be, according to
the spreadsheet). 

Regarding the secondary sorting, it seems to be working for B sizes, but
not for KB and MB sizes, which makes me think this is probably related to
rounding. 

I've attached a third version of the spreadsheet with my comments in red.

Cheers

Belén

On 07/04/2014 22:10, "Lerner, Dave" <[email protected]> wrote:

>Version 2 review request for bugzilla 5778 (bugzilla 6061 in branch
>already accepted)
>
>bugzilla 5778 sorting detail page
>branch: lerner/bz6061-bz5778
>base: master f688f6b566f455eb55d6e549 bitbake: bitbake: cooker: mark
>setFeatures command ...
>
>HTML5 validation:  Done on all relevant pages
>WS-EOL validation: Checked
>
>Unit tests:  See attached spreadsheet for version 2 tests
>
>As before, recipe detail sorting is not implemented.  David Reyna will
>implement that after you have accepted this push.
>
>Note that bugzilla 6061, also in this branch, was previously accepted by
>Belen.
>
>Regards,
>Dave Lerner
>
>

Attachment: defectsv3.ods
Description: defectsv3.ods

-- 
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

Reply via email to