Him This looks nice - thank you. I'm gonna squash top two commits before testing and submitting upstream.
Cheers, Alex On Mon, May 12, 2014 at 9:19 AM, Chisanovici, IonutX < [email protected]> wrote: > Hi Alex, > > Patch was updated as requested, please review. > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=ichisanx/master > Cheers, > Ionut C > > From: Damian, Alexandru [mailto:[email protected]] > Sent: Thursday, May 08, 2014 4:04 PM > To: Chisanovici, IonutX > Cc: [email protected] > Subject: Re: [Toaster] [review-request] ichisanx/master > > Hello, > This patch adds a lot of white space errors - please correct these. > > Also, please don't do raw SQL queries,e.g. > self.return_query_rows("SELECT id, sstate_result FROM orm_task WHERE > outcome IN (0,4);") > Instead, please use the Django QuerySet API to talk to the database and > retrieve the objects you need. > Thank you, > Alex > > On Tue, May 6, 2014 at 12:31 PM, Chisanovici, IonutX < > [email protected]<mailto:[email protected]>> wrote: > Hi guys, > > I finished the integration/migration between orm toaster backend tests and > oe-selftest. This is covering the first 4 steps from 6214< > https://bugzilla.yoctoproject.org/show_bug.cgi?id=6214> > You can find it on my poky-contrib branch: > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=ichisanx/master > > Can you please review them and merge them into project ? > > Cheers, > Ionut C > > > > -- > _______________________________________________ > toaster mailing list > [email protected]<mailto:[email protected]> > https://lists.yoctoproject.org/listinfo/toaster > > > > -- > Alex Damian > Yocto Project > SSG / OTC > -- Alex Damian Yocto Project SSG / OTC
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
