Hi Alex, I just had a look at the all layers page in toaster/master:1d5f1bc53b569d06ed6f6b18445a541b22048951
This is in pretty good shape. The stuff I've found should be easy to fix, except for the Poky openembedded-core issue, which we need to discuss. The list is below. I've also opened https://bugzilla.yoctoproject.org/show_bug.cgi?id=6861 For the filter updates. * All layers page review * * The 'show rows' menu seems broken: when I visit the page is set to 10, but the page shows 100 layers per page. Changing the value in the menu works, and then the value selected is remembered, so the problem seems to happen only the first time you load the page. * In a project with release 'master' that adds the local layers by default to the project configuration, adding any layer will show a dependency on the openembedded-core [OpenEmbedded | master] layer. We need to do something about this: people will just not get why this is happening, and they'll end up with 2 openembedded-core layers in their project. * We need to apply the .lead class to the add and delete layers notifications * In the add layer notification for multiple layers, we are missing a space between the ':' after the project name and the first layer name * The dependencies modal dialog has an extra 20px of margin at the bottom, below the buttons, that make it look a bit weird. Those 20px come from the form tag, and are needed in other forms, but we can probably just apply a margin: 0px; style to the form id #dependencies_modal_form in default.css and that should fix it. * The no results page for search is not in place * When I apply a filter (for example, a layer source one) the page heading is not changing to tell me how many layers are returned by the filter. * When the description field is empty, the table cell should be blank. Right now it shows 'none' * Notifications text: I am keen on keeping notifications consistent across all pages, so the add and delete layer notifications in the all layers page should be as similar as possible to the ones you get in the project page. So, for adding layers, they should say: "You have added 1 layer to PROJECT_NAME: LAYER_NAME" "You have added 2 layers to PROJECT_NAME: LAYER_NAME_1, LAYER_NAME_2" For deleting layers, they should say: "You have deleted 1 layer from PROJECT_NAME: LAYER_NAME The table notification text is fine as is, since we need it to be as short as possible. Any questions, let me know. Belén -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
