Hi Alex, I've reviewed the 'all targets' page on toaster/master:ec1225ba4aa5ca3d92f82d624f38fabc7c5fab29
There are still a few small things left over: * Sorting by 'target' is not handling uppercase characters correctly: they are listed before the same lowercase character. * The 'show rows' menu works now, but the value doesn't seem to be set in the cookie: if I navigate away from the page and come back, the value is reset to the default value, which seems to be to 100. * The td notification when you add a layer shows for all the targets in that layer, which is a bit strange. I don't think this should happen: the td notification should only show inside the table cell containing the button you clicked. The 'add layer' button, however, should disappear from all the targets provided by that layer (as it does now), and then replaced by the 'build target' button (as it happens now). By the way, this should be the behaviour in the 'all layers' page too. * Notifications text: I am keen on keeping notifications consistent across all pages, so the add and delete layer notifications in all targets page should be exactly the same as in the all layers page. So, for adding layers, they should say: "You have added 1 layer to PROJECT_NAME: LAYER_NAME" "You have added 2 layers to PROJECT_NAME: LAYER_NAME_1, LAYER_NAME_2" For the layer delete, they should say: "You have deleted 1 layer from PROJECT_NAME: LAYER_NAME * I know you know about this one, but so that I don't forget: the local Openembedded-core still shows as 'meta' in this table. We should show 'openembedded-core' everywhere. Also, for the 'meta' layer, the layer source information is blank: I would have expected to see 'Poky' there. * When I click the 'build' button, the fade in animation for the new build item in the latest builds section of the project page is not in place. Cheers Belén -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
