Larry Isaacs wrote:
>
> When applying Gareth Morgan's bug fix for JspRuntimeLibrary in the Tomcat MAIN
> branch, a difference between the tomcat_32 and MAIN versions revealed that
> Tomcat 3.2 still has the bug discovered by Glenn Nielsen. This is where:
>
> <jsp:setProperty name="bean" property="prop" value=""/>
>
> leaves the property unchanged instead of setting it to an empty string. As Glenn
> noted, the spec calls for ignoring an empty string when param is used, i.e.:
>
> <jsp:setProperty name="bean" property="prop" param="prop"/>
>
> with a query string of "?prop=". But doesn't say to ignore it for value. This
> is easily fixed.
>
+1 to incorporate my setProperty value="" jasper 3.3dev patch into 3.2
glenn 00/08/07 12:04:37
We should also merge in to 3.2 the below patch I did for jasper in the 3.3dev
branch.
Modified: src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java
Log:
According to the JSP 1.1 spec a TLD tag attribute required and rtexprvalue
elements should accept "yes" in addition to "true". Jasper was not
recoginizing "yes" as meaning "true". Patched.
Revision Changes Path
1.25 +11 -5
jakarta-tomcat/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java
Index: TagLibraryInfoImpl.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -r1.24 -r1.25
--- TagLibraryInfoImpl.java 2000/08/04 14:57:19 1.24
+++ TagLibraryInfoImpl.java 2000/08/07 19:04:37 1.25
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java,v
1.24
2000/08/04 14:57:19 jiricka Exp $
- * $Revision: 1.24 $
- * $Date: 2000/08/04 14:57:19 $
+ * $Header:
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java,v
1.25
2000/08/07 19:04:37 glenn Exp $
+ * $Revision: 1.25 $
+ * $Date: 2000/08/07 19:04:37 $
*
* The Apache Software License, Version 1.1
*
@@ -492,12 +492,18 @@
name = t.getData();
} else if (tname.equals("required")) {
Text t = (Text) e.getFirstChild();
- if (t != null)
+ if (t != null) {
required = Boolean.valueOf(t.getData()).booleanValue();
+ if( t.getData().equalsIgnoreCase("yes") )
+ required = true;
+ }
} else if (tname.equals("rtexprvalue")) {
Text t = (Text) e.getFirstChild();
- if (t != null)
+ if (t != null) {
rtexprvalue =
Boolean.valueOf(t.getData()).booleanValue();
+ if( t.getData().equalsIgnoreCase("yes") )
+ rtexprvalue = true;
+ }
} else if (tname.equals("type")) {
Text t = (Text) e.getFirstChild();
if (t != null)
----------------------------------------------------------------------
Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder |
MOREnet System Programming | * if iz ina coment. |
Missouri Research and Education Network | */ |
----------------------------------------------------------------------
