Re: cvs commit:jakarta-tomcat/src/examples/WEB-INF/classes/examples ShowSource.java

[Jon Stevens]

on 12/9/2000 7:07 PM, "[EMAIL PROTECTED]"
<[EMAIL PROTECTED]> wrote:

> +            (jspFile.toUpperCase().indexOf("/WEB-INF/") != 0) ||
> +            (jspFile.toUpperCase().indexOf("/META-INF/") != 0))

Seems like it would be better to define this as a constant somewhere...

public static final String WEB_INF = "/WEB-INF";

Also, I think you should remove the trailing / because the extra character
comparison isn't needed and could cause issues if it isn't there (although
it probably wouldn't be...). :-)

-jon

-- 
Honk if you love peace and quiet.