David Rees wrote:

> Replying to my own message here,
>
> Anyone have any technical comments on the message below?  I think that
> printing a stack dump in this case can be very useful, but someone else may
> have a different view.
>

For developers, you certainly want to be able to see the stack traces.  However,
many developers do *not* want such cruft showing to users -- so it was made
configurable (thanks to the efforts of Larry Isaacs) -- see the <ContextManager>
attribute called "showDebugInfo" in the conf/server.xml file.

It looks like this case was missed.  I'm +1 on adding a stack trace, but it
should be made conditional just like other stack traces are.

>
> Thanks,
> Dave
>

Craig


>
> > -----Original Message-----
> > From: David Rees [mailto:[EMAIL PROTECTED]]
> > Sent: Tuesday, December 19, 2000 8:53 PM
> > To: Tomcat Dev List
> > Subject: TC 3.2 - Better logging messages when something bad happens?
> >
> >
> > While doing some development, I started getting this Exception:
> >
> > org.apache.jasper.JasperException: error in invoking method
> >         at
> > org.apache.jasper.runtime.JspRuntimeLibrary.createTypedArray(JspRu
> > ntimeLibra
> > ry.java:353)
> >         at
> > org.apache.jasper.runtime.JspRuntimeLibrary.introspecthelper(JspRu
> > ntimeLibra
> > ry.java:194)
> >
> > I was trying to populate a bean with an array from a form, but
> > the bean was
> > throwing an exception during the population.  The confusing part was that
> > there was nothing in any logs to help me figure out what was going on
> > because the JspRuntimeLibrary was catching the exception and
> > suppressing the
> > real error message.
> >
> > Simply printing out a stack trace like this helped me find the
> > problem in no
> > time (diff against TC 3.2.1 release):
> >
> > ---
> > ./src/share/org/apache/jasper/runtime/JspRuntimeLibrary.java.orig   Tue
> > Dec 19 20:51:23 2000
> > +++ ./src/share/org/apache/jasper/runtime/JspRuntimeLibrary.java
> >       Tue
> > Dec 19 20:38:50 2000
> > @@ -349,6 +349,7 @@
> >                 method.invoke (bean, new Object[] {tmpval});
> >             }
> >         } catch (Exception ex) {
> > +           ex.printStackTrace();
> >             throw new JasperException ("error in invoking method");
> >         }
> >
> >
> > Is there any reason to not include a similar patch in the official tree?
> >
> > -Dave
> >

Reply via email to