I was looking at this last night, by coincidence. It seems to me that the
class
name is encoding too much information. It's duplicating the package as part
of
the class name. I suspect it's getting confused between '/', '\',
File.separatorChar, etc.

It's also encoding characters that are legal in java class names that do not
happen to be 
Character.isLetterOrDigit(). Should probably be
Character.isJavaIdentifierStart and 
Character.isJavaIdentifierPart


-----Original Message-----
From: Tal Dayan [mailto:[EMAIL PROTECTED]]
Sent: Tuesday, January 16, 2001 3:41 AM
To: [EMAIL PROTECTED]
Subject: Proposed name encoding patch


Hello,

This is my first posting to this list so please bare with me.

We are having problems with the jsp name mangling (bug 330 at
http://znutar.cortexity.com/BugRatViewer/ShowReport/330).

Every '/' or '_' char in the jsp path is converted to 6 chars which easily
extend the file path beyond Win NT limitation of 256 chars. As a result, the
JSP compilation fails with the following error:

org.apache.jasper.JasperException: Unable to compile class for JSPerror:
Can't write:

D:\tomcat\appserv\work\localhost_8080\system\admin\modes\start\account\_0002
fsystem_0002fadmin_0002fmodes_0002fstart_0002faccount_0002fpage_0005fadmin_0
005fstart_0005faccount_0005fpassword_0002ejsppage_0005fadmin_0005fstart_0005
faccount_0005fpassword_jsp_0.class

A quick look at the code reveals that the mangling is done by the method
CommandLineCompiler.mangleChar() so we plan to modify the method to generate
a more compact encoding, especially for common chars such as '/', '_', and
'.'.

What is the view of the list regarding the proposed modification and how
should we proceed to maximize the changes that our patch will be included in
the official Tomcat code ?

Thanks,

Tal


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
<><><><><><><><><><><><><><><><><><><><><>This electronic mail transmission
may contain confidential information and is intended only for the person(s)
named.  Any use, copying or disclosure by any other person is strictly
prohibited.  If you have received this transmission in error, please notify
the sender via e-mail. <><><><><><><><><><><><><><><><><><><><><>

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]

Reply via email to