On Thu, 29 Mar 2001, Mel Martinez wrote:

> activities that should be orthogonal.  The only
> dependency should be that the Compiler is a consumer
> of the products of the Mangler.

+1

> I think the problem starts with the idea to make a
> JspLoader that 'loads JSP files just as if they were

JspLoader is a special thing - it's a great idea ( well, the 
new model used by JspInterceptor does the same thing
in a much cleaner way ).

But in any case, should be independent of everything 
else - just a component that may be used by the 
"container adapter" classes.

Costin


> classes'.  That then broke down into creating a Jsp
> Compiler that turned JSP files into classes.  That
> finally breaks down when you realize that you have to
> have an actual javac compiler to turn the .java files
> into classes.  The JspCompilationContext (originally
> the JspEngineContext) was an attempt to tie all these
> together with one big payload to carry information
> around with.  But all that information isn't needed in
> every place and further, some of that information
> would be better and more efficiently retrieved
> elsewhere than from the JspCompilationContext.
> 
> By this I mean that currently the
> JspCompilationContext provides information relevant to
> the page life cycle such as the JspFile, the
> OutputDir, Servlet Class and Package names, etc. etc.
> - yet JspCompilationContext is a _request_ level
> object!  It is created once for every request!  This
> has got to be refactored.
> 
> Basically, there are some distinctly separate services
> used during the jsp page life cycle and the request
> life cycle that should be factored out and made
> distinct from each other.
> 
> More later.  I've got to go interview someone.
> 
> Cheers,
> 
> Mel
> 
> 
> > The classes that implement JspCompilationContext
> > look to me like they don't
> > all belong in the same package, unless everything
> > here is in the same
> > package. They are interface classes between the
> > Jasper compiler and the
> > outside invoker of the compiler. 
> >  
> > 
> > Here are the classes I'm talking about
> > 
> > http://www.panix.com/~sdowney/compilers.gif
> > 
> > and the entire compiler package
> > 
> >
> http://www.panix.com/~sdowney/org.apache.jasper.compiler.gif
> > 
> > (courtesy Together J)
> > 
> > 
> > 
> > <><><><><><><><><><><><><><><><><><><><><>This
> > electronic mail transmission
> > may contain confidential information and is intended
> > only for the person(s)
> > named.  Any use, copying or disclosure by any other
> > person is strictly
> > prohibited.  If you have received this transmission
> > in error, please notify
> > the sender via e-mail.
> <><><><><><><><><><><><><><><><><><><><><>
> 
> 
> __________________________________________________
> Do You Yahoo!?
> Get email at your own domain with Yahoo! Mail. 
> http://personal.mail.yahoo.com/?.refer=text
> 

Reply via email to