Hi Jochen,
Thank you for this patch - it is something very needed. I don't think this
can make it for 3.2.2 release ( but it can be made available for people to
compile as a separate module), but it'll be available for 3.3 ( I hope
in the default distribution - but we do have the option of making it a
module ).
Please send the source file - you attached a .class :-)
> 1.) I did not find support for something similar in TomCat 3.2.1. I
> may be wrong, though. Did I miss something? Or is there something
> comparable in later versions?
No, there isn't ( but 4.0 has a very similar thing ).
( we expect tc3 to be used with apache - and use apache logging facility.
Standalone use as a server is not the main target for TC3 )
> 2.) Is a RequestInterceptor the appropriate place to implement request
> logs? Any other suggestions?
Yes. In 3.3 there is only one class - BaseInterceptor - that combines all
server hooks.
> 3.) Apache httpd access logs contain an part "first line of the request",
> typically something like
>
> GET /index.html HTTP/1.0
>
> I did rebuild this functionality using getMethod(), getRequestURI(),
> getQueryString() and getProtocol() from the HttpServletRequest
> interface.
> IMO it should be done in another way. Any suggestions?
I'll take a look.
> 4.) If the answer to 1.) is no: Would this file be accepted as a submission,
> after whatever changes, of course?
+1 for 3.3,
+1 for checking the code in for 3.2 ( but not enable it be default ) - it
can't hurt in any way code stability. ( but it's Marc's call )
Costin
