Since I'm going to need support for chunked requests in 3.3 anyway, I'm
going ahead with the port of my 3.2.2 changes. I hope to have it in a
couple of days.
>Questions :
>
>- Does the java part need to know that the incoming data came in CHUNKED ?
The Java side can figure it out if the Content-Length is not set. Still,
the Content-Length might be set even when the transfer was chunked. Not
sure how much value would be added in knowing this explicitly.
>- Should we add others HTTP/1.1 commands like Range, Accept-Ranges, CONNECT
>?
I suppose these could be helpful but I haven't thought too much about it.
In general, it seems like a good idea to leverage as much as possible from
the transport.
-David
>-----Original Message-----
>From: Schreibman, David [mailto:[EMAIL PROTECTED]]
>Sent: Tuesday, August 28, 2001 5:17 PM
>To: '[EMAIL PROTECTED]'
>Subject: RE: cvs commit:
>jakarta-tomcat/src/share/org/apache/tomcat/util/t estHeader.java
>HttpRequest.java
>
>
>For whatever it's worth, here are some changes I made to the
>3.2.2 code base
>to add support for chunked requests. I just did the work a
>few days ago and
>am still in the process of moving them to 3.3. Still, since
>the topic came
>up now I thought it would be helpful to share my approach. I have been
>running some heavy stress tests on this and have not seen any
>problems yet.
>It would be great to run the changes through some unit tests as well.
You may have noticed that mod_jk in TC 3.3 is
different from the one in TC 3.2.
Also Ajp13 in Tomcat 3.3 (java) is also different since using
directly InputStream.
And mod_jk in jakarta-tomcat-connectors is
also very different since there was some refactoring.
>From what I saw it seems you're on the right way,
and I'm waiting to see your port to TC 3.3.
Or if you like, I could try to port it to both 3.3 and J-T-C.
I've got many questions here and some refactory should be
done on that part of the code later, I don't like very much
the way the communication is done. May be something to rewrite
completly to Ajp14, adding others new commands (CHUNKED-DATA).
The goal will be to have a simpler (and so fastest) way to
do the transfert.
Questions :
- Does the java part need to know that the incoming data came in CHUNKED ?
- Should we add others HTTP/1.1 commands like Range, Accept-Ranges, CONNECT
?
What do you think about that ?
